Skip to content

Don't show a scary chat error for non-critical update/MOTD check failures #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kovalancik06-max wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Don't show a scary chat error for non-critical update/MOTD check failures #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/io/github/quantizr/dungeonrooms/DungeonRooms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ public void onServerConnect(FMLNetworkEvent.ClientConnectedToServerEvent event)
logger.info("DungeonRooms: MOTD has been checked");
}
} catch (IOException | InterruptedException e) {
mc.thePlayer.addChatMessage(new ChatComponentText(EnumChatFormatting.RED + "Dungeon Rooms: An error has occured. See logs for more details."));
e.printStackTrace();
// Update check / MOTD fetch are non-critical, and commonly fail on outdated Java
// trust stores (SSLHandshakeException) - don't alarm the player in chat for this.
logger.warn("DungeonRooms: Failed to check for updates or fetch MOTD", e);
}

}).start();
Expand Down