fix: eager load Position and TelegramUser to eliminate N+1 queries in…#153
Open
chuks68 wants to merge 1 commit into
Open
fix: eager load Position and TelegramUser to eliminate N+1 queries in…#153chuks68 wants to merge 1 commit into
chuks68 wants to merge 1 commit into
Conversation
… get_users_for_notifications
YaronZaki
requested changes
Jun 20, 2026
YaronZaki
left a comment
YaronZaki
left a comment
Contributor
There was a problem hiding this comment.
Love the joinedload fix — clean way to kill the N+1. CI is failing on the test job though, so please address that and push a fix before we can land this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #65 This PR resolves the N+1 query issue in UserDBConnector.get_users_for_notifications by eager loading the related Position and TelegramUser entities using SQLAlchemy's joinedload.
Configured positions and telegram_user relationships on the User model.
Updated the query in get_users_for_notifications to apply .options(joinedload(User.positions), joinedload(User.telegram_user)).
Re-mapped query outputs to return the expected (contract_address, telegram_id) tuple type to preserve the existing signature and behavior.