refactor: Migrate Position, ExtraDeposit, and Vault amount columns to…#152
Open
chuks68 wants to merge 1 commit into
Open
refactor: Migrate Position, ExtraDeposit, and Vault amount columns to…#152chuks68 wants to merge 1 commit into
chuks68 wants to merge 1 commit into
Conversation
chuks68
force-pushed
the
refactor/amount-numeric
branch
from
9fc83c4 to
fc027bc
Compare
YaronZaki
requested changes
Jun 20, 2026
YaronZaki
left a comment
YaronZaki
left a comment
Contributor
There was a problem hiding this comment.
NUMERIC(38,18) is the right call for these amounts. CI is red on both the unit and integration tests though — please get it green before we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #77 The amount column in the Position, ExtraDeposit, and Vault models was previously a String, causing type‑mismatch bugs and requiring runtime casts to NUMERIC for every calculation.
This PR migrates those columns to NUMERIC(38, 18), updates the corresponding CRUD logic to operate on native Decimal values, adds an Alembic migration to perform the schema change safely, and adjusts test expectations.
Changes include:
Model definitions updated (models.py).
Removal of cast(..., Numeric) from query logic (position.py).
Direct Decimal math in vault balance updates (deposit.py).
Alembic migration script (20230620_amount_numeric.py).
Test suite updated (deposit_db_tests.py).
All tests run successfully (pytest), confirming functional correctness.