security: limit request body size to 1MB in FastAPI and Nginx#147
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #46 Title: security: limit request body size to 1MB in FastAPI and Nginx
Summary No request body size limits were configured in FastAPI or Nginx. Large payloads could cause DoS via memory exhaustion before application-level validation runs. This PR introduces size limits at both layers to mitigate this vulnerability.
Changes
Nginx Configs: Added client_max_body_size 1M; to both
quantara.conf
and
quantara_dev.conf
to reject oversized requests at the edge.
FastAPI Middleware: Implemented a custom ASGI
MaxBodySizeMiddleware
to enforce a 1MB limit on request bodies and return a 413 Request Entity Too Large response.
App Integration: Registered the middleware in
main.py
before the rate limiter middleware.
Integration Tests: Added
test_body_size_limit.py
to verify request body size limitation for normal, chunked/streamed, and oversized requests.