Bugfix/group invite expiry#286
Open
QuickMythril wants to merge 27 commits into
Open
Conversation
added 27 commits
December 4, 2025 21:11
|
Docs of this PR should be gathered in a dedicated folder ("group_invite_expiry" for example). |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285 - Bug: GROUP_INVITE expiration not enforced (invites never expire)
Summary
groupInviteExpiryHeightfeature trigger (enum entry + getter) and wire it through mainnet, testnet, and all test-chain fixtures; startup now validates the trigger presence.Group.join(...)gated by the trigger: invite-first joins use join tx timestamps with an inclusive boundary andexpiry == nullsentinel; expired invites are treated as absent and fall back to join requests; pre-trigger behavior is unchanged. Join-first auto-approvals remain TTL-agnostic (any invite approves a pending request).GroupsResource(inclusive boundary,expiry == nullnever expires, skip when no tip) and document the behavior in swagger.INVITE_EXPIRATION.md,IMPLEMENTATION.md,CONSENSUS_CHANGE.md) with final semantics, activation plan, join-first clarifications, and activation rollout guidance.GroupInviteFilteringApiTestsclass.Tests
mvn -q -DskipTests=false -Dtest=org.qortal.test.group.MiscTests testmvn -q -DskipTests=false -Dtest=org.qortal.test.api.GroupInviteFilteringApiTests testFollow-up for activation
groupInviteExpiryHeightfor mainnet once network coverage is sufficient; keep the placeholder until then.