Add safe shape checking to synth_cz_depth_line_mr#16154
Merged
alexanderivrii merged 2 commits intoQiskit:mainfrom May 7, 2026
Merged
Add safe shape checking to synth_cz_depth_line_mr#16154alexanderivrii merged 2 commits intoQiskit:mainfrom
synth_cz_depth_line_mr#16154alexanderivrii merged 2 commits intoQiskit:mainfrom
Conversation
This was previously unverified, which could lead to Rust panicking if the matrix was taller than it was wide.
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 25499096380Coverage decreased (-0.03%) to 87.602%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions39 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
ShellyGarion
reviewed
May 7, 2026
ShellyGarion
approved these changes
May 7, 2026
Member
ShellyGarion
left a comment
There was a problem hiding this comment.
LGTM. thanks for fixing this so quickly!
@alexanderivrii - would you like to review it too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously unverified, which could lead to Rust panicking if the matrix was taller than it was wide.
Fix #16152
AI/LLM disclosure