Template library#16131
Draft
1ucian0 wants to merge 38 commits intoQiskit:mainfrom
Draft
Conversation
Member
|
could we perhaps merge #15944 (adding global phases to some template circuits) before rearranging the template library? |
ShellyGarion
reviewed
May 6, 2026
| « └─────────┘└─────────┘└─────────┘ | ||
| «q_1: ───────────────────────────────── | ||
| « | ||
| """ |
Member
There was a problem hiding this comment.
see this comment: https://github.com/Qiskit/qiskit/pull/15944/changes#r3049543999
one should replace RZ by Rz, RX by RX, RZX by Rzx etc.
(this is relevant to all the RZX cirucits)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #8191
AI/LLM disclosure