Skip to content

Fix issue #16097 - Fix qasm3.dumps_experimental delay units#16114

Open
pedro2mj wants to merge 6 commits intoQiskit:mainfrom
pedro2mj:main
Open

Fix issue #16097 - Fix qasm3.dumps_experimental delay units#16114
pedro2mj wants to merge 6 commits intoQiskit:mainfrom
pedro2mj:main

Conversation

@pedro2mj
Copy link
Copy Markdown

AI/LLM disclosure

  • I didn't use LLM tooling, or only used it privately.
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

@pedro2mj pedro2mj requested a review from a team as a code owner April 30, 2026 12:03
@pedro2mj pedro2mj requested a review from mtreinish April 30, 2026 12:03
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Apr 30, 2026
@qiskit-bot
Copy link
Copy Markdown
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 30, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me, thanks for fixing it. But before we merge it could you add a test that covers these fixes. Additionally, could you add a release note for the fix. The process for this is documented here: https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#release-notes

@ShellyGarion ShellyGarion linked an issue Apr 30, 2026 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25164307073

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.02%) to 87.583%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 2 uncovered changes across 2 files (0 of 2 lines covered, 0.0%).
  • 7 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
crates/qasm3/src/ast.rs 1 0 0.0%
crates/qasm3/src/exporter.rs 1 0 0.0%

Coverage Regressions

7 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
crates/qasm2/src/lex.rs 5 91.52%
crates/circuit/src/parameter/parameter_expression.rs 1 90.53%
crates/qasm2/src/expr.rs 1 93.82%

Coverage Stats

Coverage Status
Relevant Lines: 121251
Covered Lines: 106195
Line Coverage: 87.58%
Coverage Strength: 964696.81 hits per line

💛 - Coveralls

@ShellyGarion ShellyGarion changed the title Fix issue #16097 Fix issue #16097 - Fix qasm3.dumps_experimental delay units May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

qasm3.dumps_experimental gets some delay units wrong

5 participants