Skip to content

Switch details to Accordion in content#4724

Open
frankharkins wants to merge 1 commit intomainfrom
FH/accodions-migration-pt-2
Open

Switch details to Accordion in content#4724
frankharkins wants to merge 1 commit intomainfrom
FH/accodions-migration-pt-2

Conversation

@frankharkins
Copy link
Member

@frankharkins frankharkins commented Feb 26, 2026

This PR switches some <details> tags to the new <Accordion> component.

I haven't switched all the tags; some will require rewording to make the titles fit on one line. I only switched tags that didn't require any rewording.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

<details>
<summary>**Observable estimation**</summary>

These tutorials focus on estimating physically meaningful quantities, such as energy or correlation values, by preparing quantum states and measuring observables. Techniques include both variational and Trotterized circuit approaches that balance circuit expressiveness with circuit-depth efficiency. Emphasis is placed on workflows that reduce quantum resource demands while maintaining accuracy, and enabling practical estimation of observables in chemical and physical systems.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this text intentionally removed? See also text removed from lines 66, 81, 135, 157, and 173.

"</details>"
"<Accordion>\n",
" <AccordionItem title='Code for automated selection of \"zig-zag\" layout'>\n",
" <CodeCellPlaceholder tag=\"id-automated-layout-code\" />\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I'm surprised how much indentation (particularly on the right side!) of the code block happened when it was put inside the accordion. Do we have any control over how much margin is put around a code block inside the accordion? The image I attach here shows the code block in the accordion on the top, contrasted with a code block not in an accordion on the bottom.
Screenshot 2026-02-27 at 9 13 54 AM

"<em>mathematical details</em>\n",
"\n",
"</summary>\n",
"<AccordionItem title=\"<em>mathematical details</em>\">\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<AccordionItem title=\"<em>mathematical details</em>\">\n",
"<AccordionItem title=\"<em>Mathematical details</em>\">\n",

pre-existing erroneous lower-case m

"<Accordion>\n",
"\n",
"</summary>\n",
"<AccordionItem title=\"<em>mathematical details of hash collisions</em>\">\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<AccordionItem title=\"<em>mathematical details of hash collisions</em>\">\n",
"<AccordionItem title=\"<em>Mathematical details of hash collisions</em>\">\n",

Copy link
Collaborator

@beckykd beckykd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be gorgeous! Thanks Frank!!

<summary>
Does Qiskit Runtime local testing mode support different execution modes?
</summary>
<span id="parallel"></span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ID belongs before the next accordion; not this one.


</summary>
<Accordion>
<AccordionItem title="Optional reading — click on the triangle to read more about the experiment">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<AccordionItem title="Optional reading — click on the triangle to read more about the experiment">
<AccordionItem title="Optional reading — expand to read more about the experiment">

"\n",
"</summary>\n",
"</AccordionItem>\n",
"<AccordionItem title=\"What are the principal advantages to SKQD over (a) SQD, and (b) KQD?\">\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<AccordionItem title=\"What are the principal advantages to SKQD over (a) SQD, and (b) KQD?\">\n",
"<AccordionItem title=\"What are the principle advantages to SKQD over (a) SQD, and (b) KQD?\">\n",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm now that I see this, I think principal here is being used correctly, as an adjective - the most important advantages. Principle is only a noun, I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants