Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This stacked Sprint 2 PR moves Shop V2 from its local prototype toward production-capable commerce. It is intentionally based on
feature/commerce-foundation-sprint-1so reviewers see only Sprint 2 changes.Milestone status
Checkpoint 01 ? persistent cart
Commit:
76e3014 feat: persist immutable commerce configurationsTag:
checkpoint/commerce-s2-01-persistent-cartImplemented:
COMMERCE_PERSISTENCE_ENABLED=falseValidation:
npm test: 31 passed, 1 skipped live smoke testnpm run test:e2e: 1 passed at 375?812npm run typecheck: passednpm run lint: passed with 23 pre-existing warnings and no errorsnpm run build: passedSafety
master.Checkpoint 02 ? validated curated Printify catalog
Commit:
5c0aba6 feat: add validated curated Printify catalogTag:
checkpoint/commerce-s2-02-live-catalogImplemented:
Validation:
Safety: no Printify write endpoint was called and no remote database migration was applied.
Checkpoint 03 ? curated designs and collections
Commit:
d2645ec feat: connect curated designs and collections to Shop V2Tag:
checkpoint/commerce-s2-03-curated-designsImplemented:
/designs,/designs/[slug],/drops,/drops/[slug], and/collections/[slug]Validation:
Safety: no remote migration or production deployment was performed.
Checkpoint 04 ? secure Stripe test checkout
Commit:
a2ddce2 feat: add secure Stripe test checkoutTag:
checkpoint/commerce-s2-04-secure-checkoutImplemented:
Validation:
Blocker: the local environment contains a live-mode Stripe secret, not a test key. The implementation rejects it and no Stripe API request or payment was attempted. A dedicated
sk_test_...key is required for an external test Checkout smoke test.Checkpoint 05 ? idempotent dry-run Printify fulfillment
Commit:
f7c285c feat: add idempotent dry-run Printify fulfillmentTag:
checkpoint/commerce-s2-05-fulfillmentImplemented:
PRINTIFY_FULFILLMENT_MODE=disableddefault with disabled/dry-run/live validationValidation:
Safety: automated tests made zero Printify writes. No live order was created or sent to production.
Milestone 7 ? hardened commerce webhooks and order state
Commit:
a7da055 feat: harden commerce webhooks and order stateImplemented:
X-Pfy-SignatureformatValidation:
Safety: no Printify write, Stripe API call, remote migration, or production deployment occurred. The existing
checkpoint/commerce-s2-05-fulfillmenttag was not moved; published tags remain immutable.Milestone 7 ? hardened commerce webhooks and order state
Commit:
a7da055 feat: harden commerce webhooks and order stateImplemented:
X-Pfy-SignatureformatValidation:
Safety: no Printify write, Stripe API call, remote migration, or production deployment occurred. The existing
checkpoint/commerce-s2-05-fulfillmenttag was not moved; published tags remain immutable.Milestone 7 — hardened commerce webhooks and order state
Commit:
a7da055 feat: harden commerce webhooks and order stateImplemented:
X-Pfy-SignatureformatValidation:
Safety: no Printify write, Stripe API call, remote migration, or production deployment occurred. The existing
checkpoint/commerce-s2-05-fulfillmenttag was not moved; published tags remain immutable.Milestone 8 — end-to-end commerce flow
Commit:
8e7defd test: complete Shop V2 commerce flowImplemented:
NODE_ENV=productionValidation:
Safety: the harness is disabled by default, requires an explicit test-mode flag plus request secret, and returns 404 in production. No Stripe, Printify, remote database, or deployment write occurred.
Milestone 9 — Vercel preview (blocked at environment gate)
Commit:
4f47200 chore: add preview health checkPreview deployment:
https://printme-izd4qjubb-qaliais-projects.vercel.appObserved:
READYtarget: null), not production/api/healthreturns 200 withstatus: ok/shop-v2,/designs, and design detail remain feature-gated 404s because the preview environment does not haveNEXT_PUBLIC_COMMERCE_V2_ENABLED=trueBlockers:
Safety:
checkpoint/commerce-s2-06-preview-releasewas not created because the release gate did not pass