Skip to content

XRobot 1.0: merge feat/static-assembly-20260915 into dev - #5

Merged
Jiu-xiao merged 3 commits into
devfrom
feat/static-assembly-20260915
Oct 4, 2026
Merged

Jiu-xiao merged 3 commits into
devfrom
feat/static-assembly-20260915

Conversation

@Jiu-xiao

@Jiu-xiao Jiu-xiao commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Merges the XRobot 1.0 work into dev. The release order and the acceptance checks are described in RELEASE.md of xrobot-org/XRobot.

Summary by Sourcery

Align firmware memory mapping and artifact generation with the XRobot 1.0 build workflow.

Bug Fixes:

  • Correct the STM32 linker placement for the D1 RAM section.

Enhancements:

  • Move firmware HEX and BIN generation into the post-build workflow so images are emitted alongside the ELF output.

Documentation:

  • Clarify that CI regenerates the four generated files under User/.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Jiu-xiao, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 23 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Oct 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This release merge consolidates firmware artifact generation into cmake/LibXR.CMake as a post-link action, updates the H723 linker script to place .ram_d1 sections in D1 RAM, and aligns README CI documentation with the current four-file regeneration workflow.

File-Level Changes

Change Details Files
Move firmware image generation from standalone build targets into a post-build step attached to the application target.
  • Remove the create_hex_output and create_bin_output helper targets from the top-level build.
  • Generate Intel HEX and stripped binary files beside the ELF after each application link, using target-file generator expressions and VERBATIM.
  • Review output naming, working-directory behavior, and whether downstream flashing/release steps still find the generated artifacts.
CMakeLists.txt
cmake/LibXR.CMake
Correct linker placement for AXI/D1 RAM sections.
  • Map .ram_d1 and wildcard variants into the RAM_D1 region instead of matching .axi_ram sections.
  • Verify that source annotations and generated objects use the renamed section convention and that memory usage remains valid.
STM32H723xG_flash.ld
Update documentation to describe the narrower CI regeneration scope.
  • Clarify that CI regenerates and compares four files under User/ rather than the previously listed generated files.
  • Keep the English and Chinese workflow descriptions aligned.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Jiu-xiao
Jiu-xiao merged commit 298d7bc into dev Oct 4, 2026
3 of 5 checks passed
@Jiu-xiao
Jiu-xiao deleted the feat/static-assembly-20260915 branch October 4, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant