Repository navigation
Conversation
Merged master commits and verdicts: - bbe0670 fix: require configured SuperPower provider superseded: SuperPower& is a reference in the static-assembly constructor; the manifest already declares QDU-Robomaster/SuperPower. Conflicts resolved in favour of the static-assembly branch.
XRobot accepts only module_description, description, depends and standalone in the module manifest.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev.
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
Reviewer's GuideThis PR migrates PowerControl to XRobot 1.0 static module assembly by simplifying its construction and manifest, adopts the shared dev-based Module CI workflow, and updates documentation and licensing for the new integration and release conventions. Sequence diagram for static PowerControl assembly and control cyclesequenceDiagram
participant XRobot
participant SuperPower
participant PowerControl
participant Chassis
XRobot->>PowerControl: construct(SuperPower&, is_helm, chassis_static_power_loss, motor counts)
Chassis->>PowerControl: SetMotorData3508(output_current, rotorspeed_rpm, speed_error)
Chassis->>PowerControl: SetMotorData6020(output_current, rotorspeed_rpm, speed_error)
Chassis->>PowerControl: CalculatePowerControlParam()
PowerControl->>SuperPower: GetChassisPower()
PowerControl->>SuperPower: IsOnline()
Chassis->>PowerControl: OutputLimit(max_power)
PowerControl->>PowerControl: solve_current_for_power(...)
Chassis->>PowerControl: GetPowerControlData()
PowerControl-->>Chassis: PowerControlData
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The PR changes the module's construction and integration API while also moving CI to a mutable reusable workflow and dev-branch dependencies. If the power-control behavior or generated integration is wrong, the robot could receive incorrect motor currents and potentially suffer a hardware or operational incident; reverting restores the prior source but cannot undo damage or operation that already occurred.
XRobot 1.0: merge feat/static-assembly-20260915 into dev
Apply the pre-release audit recommendations (audit/apply-20261004)
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate the PowerControl module to the XRobot 1.0 static assembly conventions and shared module tooling.
New Features:
Enhancements:
CI:
Documentation:
Chores: