Repository navigation
Conversation
Merged master commits and verdicts: - 0a5efcb fix: validate required launcher providers before setup superseded: CMD and the friction/trigger motors are references in the static-assembly constructor, Referee stays an optional pointer; Motor and Referee are already declared in the manifest. Conflicts resolved in favour of the static-assembly branch.
Optional dependencies are pointer parameters without a default argument; configurations pass nullptr to omit them.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev.
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
InfantryLauncher subscribed to "launcher_cmd" and "launcher_ref" by fixed names while CMD and Referee publish them under configurable ones. Param gains launcher_cmd_topic_name and launcher_ref_topic_name, defaulting to the old names.
List the new topic name parameters with their defaults, show them in the configuration example, and say which publisher setting each must match.
Reviewer's GuideThis PR migrates InfantryLauncher to XRobot 1.0 static assembly by changing manifest and constructor dependency handling, exposing topic names and runtime configuration through Sequence diagram for static module initialization and topic subscriptionsequenceDiagram
participant XRobot
participant Generator as CodeGenerator
participant InfantryLauncher
participant CMD
participant RMMotor
participant Topic
XRobot->>Generator: xrobot setup
Generator->>InfantryLauncher: construct with explicit dependencies and Param
InfantryLauncher->>RMMotor: store motor references
InfantryLauncher->>CMD: GetEvent().Register(...)
InfantryLauncher->>InfantryLauncher: Thread::Create(ThreadFunc)
InfantryLauncher->>Topic: ASyncSubscriber(launcher_cmd_topic_name_)
InfantryLauncher->>Topic: ASyncSubscriber(launcher_ref_topic_name_)
Topic-->>InfantryLauncher: command and referee data
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate the InfantryLauncher module to the XRobot 1.0 static assembly conventions and shared module infrastructure.
New Features:
Enhancements:
CI:
Documentation: