Repository navigation
Conversation
Merged master commits and verdicts: - 46b3cb4 fix: harden HostData provider and topic handling - CMD pointer overload and null check: superseded; CMD& is a reference in the static-assembly constructor; the manifest already declares CMD. - moving topic creation into the constructor: superseded; no provider validation precedes it any more. - null/size guards on the RawData callback payloads: superseded by exact typed Topic callbacks, where LibXR checks the payload type when the callback is registered; the callbacks are converted to their concrete payload types in a follow-up commit on this branch. Conflicts resolved in favour of the static-assembly branch.
The target, chassis and fire callbacks registered LibXR::RawData& payloads on typed topics, which LibXR rejects when the callback is registered. They now take const HostGimbalTarget&, const HostChassisTarget& and const LauncherCMD&; the copied values and the HostCMD() call are unchanged.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev.
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
Reviewer's GuideMigrates HostData to XRobot 1.0 static module assembly, including MODULE MANIFEST V2 metadata, typed topic callbacks, the shared CI workflow, updated usage documentation, and Apache-2.0 licensing. Sequence diagram for static HostData assembly and typed topic inputsequenceDiagram
participant XRobot
participant HostData
participant Topic
participant CMD
XRobot->>HostData: HostData(cmd, topic names)
HostData->>Topic: CreateTopic<HostGimbalTarget>()
HostData->>Topic: CreateTopic<HostChassisTarget>()
HostData->>Topic: CreateTopic<LauncherCMD>()
HostData->>Topic: RegisterCallback()
Topic-->>HostData: const HostGimbalTarget&
HostData->>HostData: HostCMD(in_isr)
HostData->>CMD: FeedAI(host_cmd)
Topic-->>HostData: const HostChassisTarget&
HostData->>HostData: HostCMD(in_isr)
HostData->>CMD: FeedAI(host_cmd)
Topic-->>HostData: const LauncherCMD&
HostData->>HostData: HostCMD(in_isr)
HostData->>CMD: FeedAI(host_cmd)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate HostData to the XRobot 1.0 static assembly conventions and shared module tooling.
New Features:
Enhancements:
CI:
Documentation:
Chores: