Repository navigation
Conversation
Merged master commits and verdicts: - 590aec6 fix: validate CMD provider before receiver setup superseded: the static-assembly constructor takes LibXR::UART& and CMD& (non-null by type, no hardware-container lookup, no pointer/reference overload pair); the manifest already declares QDU-Robomaster/CMD. Conflicts resolved in favour of the static-assembly branch.
XRobot accepts only module_description, description, depends and standalone in the module manifest.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev.
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
Reviewer's GuideMigrates the DR16 module to XRobot 1.0’s static assembly and MODULE MANIFEST V2 conventions, updates construction and dependency metadata, adopts the shared dev-branch Module CI workflow, and rewrites usage documentation with an Apache-2.0 license. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="DR16.hpp" line_range="147-149" />
<code_context>
+ DR16(
</code_context>
<issue_to_address>
**nitpick:** The constructor documentation still advertises a nonexistent `cmd_data_tp_name` parameter and omits the required `uart` parameter, so the in-code API documentation does not describe the static-assembly constructor that callers must use.
**Suggested fix:** Update the constructor comment to document `uart`, `cmd`, and `param`, and remove the stale `cmd_data_tp_name` entry.
```suggestion
* @param uart UART对象引用
* @param cmd 控制命令对象引用
* @param param Value configuration.
```
</issue_to_address>Sourcery assessment
Needs a human reviewer. The new DR16 integration directly feeds parsed UART input into CMD, so a wrong mapping, constructor wiring, or offline transition could issue incorrect robot-control commands. Reverting prevents future commands but cannot undo physical actions that occurred while the faulty code was running.
| * @param cmd 控制命令对象引用 | ||
| * @param task_stack_depth_uart UART任务栈深度 | ||
| * @param param Value configuration. | ||
| * @param cmd_data_tp_name CMD数据主题名称 |
There was a problem hiding this comment.
nitpick: The constructor documentation still advertises a nonexistent cmd_data_tp_name parameter and omits the required uart parameter, so the in-code API documentation does not describe the static-assembly constructor that callers must use.
Suggested fix: Update the constructor comment to document uart, cmd, and param, and remove the stale cmd_data_tp_name entry.
| * @param cmd 控制命令对象引用 | |
| * @param task_stack_depth_uart UART任务栈深度 | |
| * @param param Value configuration. | |
| * @param cmd_data_tp_name CMD数据主题名称 | |
| * @param uart UART对象引用 | |
| * @param cmd 控制命令对象引用 | |
| * @param param Value configuration. |
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate the DR16 module to XRobot 1.0 conventions and shared CI while updating its manifest, construction API, and user documentation.
New Features:
Enhancements:
CI:
Documentation: