Repository navigation
Conversation
Merged master commits and verdicts: - 37e85df fix: validate required chassis providers before setup - manifest constructor_args ('@nullptr' providers, length/width syntax) and depends list: superseded; the static-assembly manifest has no constructor_args and already declares BMI088, PowerControl, Referee, Motor and SuperPower. - null checks for wheel motors, CMD, PowerControl and Referee: superseded; these are references in the static-assembly constructor. - std::optional<ChassisType> deferred construction: superseded; chassis_ is constructed directly from the reference dependencies. - Helm steer-motor null checks: kept (ported). Steer motors remain optional pointers in Chassis because Omni/Mecanum do not use them, but Helm dereferences all four unconditionally; the assertions now run in the Helm constructor before its control thread is created. Conflicts resolved in favour of the static-assembly branch.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev. Carried over from the old workflow: - template arguments ["Mecanum"]
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
The chassis types subscribed to "chassis_cmd", "chassis_ref" and (omni) "gimbal_euler" by fixed names, while CMD, Referee and the AHRS modules publish them under configurable names; renaming a topic in the config silently cut the chassis off. Param gains chassis_cmd_topic_name, chassis_ref_topic_name and gimbal_euler_topic_name, defaulting to the old names, and passes them to Omni, Mecanum and Helm.
List the new topic name parameters with their defaults, show them in the configuration example, and say which publisher setting each must match.
Reviewer's GuideThis PR migrates the chassis module from the legacy dynamic/Application-based integration to XRobot 1.0 static assembly, including manifest and constructor changes, configurable topic subscriptions, shared CI adoption, and refreshed documentation and licensing. Sequence diagram for configurable chassis topic subscriptionssequenceDiagram
participant Generator as XRobot static generator
participant Chassis as Chassis
participant Controller as Mecanum Omni or Helm
participant Topics as LibXR topics
Generator->>Chassis: construct with Param
Chassis->>Controller: create concrete chassis
Controller->>Topics: ASyncSubscriber(chassis_cmd_topic_name)
Controller->>Topics: ASyncSubscriber(chassis_ref_topic_name)
alt Omni
Controller->>Topics: ASyncSubscriber(gimbal_euler_topic_name)
end
Controller->>Topics: StartWaiting()
loop control thread
Topics-->>Controller: Available()
Controller->>Topics: GetData()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. This replaces the local CI and chassis construction/control integration with a large API and runtime-behavior change, while the reusable workflow and dependencies follow mutable dev branches. A defect could drive the robot's motors or power limiting incorrectly and cause physical damage or other effects that reverting cannot undo, even though the code change itself can be reverted.
XRobot 1.0: merge feat/static-assembly-20260915 into dev
Apply the pre-release audit recommendations (audit/apply-20261004)
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate the Chassis module to XRobot 1.0 static assembly while updating its configuration, documentation, licensing, and CI integration.
New Features:
Bug Fixes:
Enhancements:
CI:
Documentation:
Chores: