Repository navigation
Conversation
Merged master commits and verdicts: - 346b06f fix: migrate topic creation to typed API already implemented: the static-assembly CMD constructor already creates the chassis/gimbal/launcher topics with LibXR::Topic::CreateTopic<T>. Conflicts resolved in favour of the static-assembly branch.
The static-assembly entry calls OnMonitor() only for modules that declare it; the empty body was left over from the removed application framework.
The XRobot ecosystem Modules are published under the Apache License 2.0; the text is identical to xrobot-org/XRobot/LICENSE.
Replace the generated inline workflow with a caller of xrobot-org/XRobot/.github/workflows/module-ci.yml, which resolves the dependencies, compiles the Module sources and a generated constructor probe against LibXR. During the coordinated 1.0 change the tools, LibXR and same-or-dev dependencies come from dev.
Describe the Module, its dependencies, its constructor (dependencies first, then the value configuration) and its use with xrobot module add / setup / instance add, with a configuration example seeded by the tool. Drop the dynamic-framework text and the dead MIGRATION.md link.
Reviewer's GuideMigrates CMD to XRobot 1.0 static module assembly by making it a standalone configurable class with MODULE MANIFEST V2 metadata, adopts the shared dev-based Module CI workflow, refreshes documentation for the new CLI and generated configuration, and adds an Apache-2.0 license. Sequence diagram for static CMD construction and command publishingsequenceDiagram
participant Main as GeneratedMain
participant CMD as CMD
participant Source as ControlSource
participant Topics as LibXRTopics
Main->>CMD: CMD(mode, chassis_cmd_topic_name, gimbal_cmd_topic_name, launcher_cmd_topic_name)
CMD->>Topics: CreateTopic<ChassisCMD>(chassis_cmd_topic_name)
CMD->>Topics: CreateTopic<GimbalCMD>(gimbal_cmd_topic_name)
CMD->>Topics: CreateTopic<LauncherCMD>(launcher_cmd_topic_name)
Source->>CMD: FeedRC(Data) or FeedAI(Data)
CMD->>CMD: ProcessAndPublish()
CMD->>Topics: Publish chassis, gimbal, and launcher commands
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. This refactors the control-command module and its generated integration, including the path that publishes chassis, gimbal, and launcher commands; a defect could send incorrect commands or permit an unintended fire command, and reverting would not undo any physical action already taken. The CI also moves execution to an external reusable workflow and mutable dev references, creating a supply-chain and build-trust dependency that should be reviewed.
XRobot 1.0: merge feat/static-assembly-20260915 into dev
把 dev 合入 master。迁移到 XRobot 1.0 的模块约定(静态装配),具体改动见下方提交列表。
Merges dev into master. Migrates the Module to the XRobot 1.0 conventions (static assembly); the commits below list the changes.
合并顺序:libxr、CodeGenerator、扩展和 XRobot 先合并并发布(xrobot 1.0.0、libxr 6.0.0、扩展 2.0.0,XRobot 打
v1);模块的 PR 在 xrobot 1.0.0 发布之后再合并,因为模块 master 合入后,xrobot 0.3.x 拉到的就是 MODULE MANIFEST V2 的模块。Merge order: libxr, CodeGenerator, the extension and XRobot are merged and released first (xrobot 1.0.0, libxr 6.0.0, extension 2.0.0, XRobot tag
v1); the Module PRs follow after xrobot 1.0.0 is released, because once a Module's master carries MODULE MANIFEST V2, xrobot 0.3.x fetches that format.验证 / Verification
提交 / Commits
Summary by Sourcery
Migrate the CMD module to the XRobot 1.0 static assembly conventions and shared module CI workflow.
New Features:
Enhancements:
CI:
Documentation: