Skip to content

117 expand and better document imputation strategy in targetencoder - #174

Merged
ZlaTanskY merged 8 commits into
developfrom
117-expand-and-better-document-imputation_strategy-in-targetencoder
May 26, 2023
Merged

117 expand and better document imputation strategy in targetencoder#174
ZlaTanskY merged 8 commits into
developfrom
117-expand-and-better-document-imputation_strategy-in-targetencoder

Conversation

@patrickleonardy

Copy link
Copy Markdown
Contributor

Expand and better document imputation strategy in target encoder

Changes made

  • added a median imputation for the target encoding.
  • changed the docstings to more easily understand what is happening
  • added some unit test to make sure that this functionality is correctly implemented

How does the solution address the problem

This PR will just add some functionality

Linked issues

Resolves #117

@patrickleonardy patrickleonardy added the enhancement New feature or request label May 12, 2023
@patrickleonardy patrickleonardy added this to the 2023-05 milestone May 12, 2023
@patrickleonardy
patrickleonardy requested a review from joostneuj May 12, 2023 13:15
@patrickleonardy patrickleonardy linked an issue May 12, 2023 that may be closed by this pull request
@ZlaTanskY
ZlaTanskY merged commit 6bc242c into develop May 26, 2023
@ZlaTanskY
ZlaTanskY deleted the 117-expand-and-better-document-imputation_strategy-in-targetencoder branch May 26, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand and better document imputation_strategy in TargetEncoder

2 participants