fix: lang filter and missing set logos on cold start#146
Merged
Conversation
… ready Cached cards without lang field defaulted all sets to JP. Default undefined lang to EN. Await set metadata fetch before marking card DB ready so logos are available on first request.
TCGdex JA API uses zero-padded localIds (neo1-001) while EN uses unpadded (neo1-1). Normalize card IDs before dedup so JA duplicates are merged with EN cards instead of appearing as separate JP-only entries with no images.
Startup now always loads from Firestore cache without TTL expiry. No more background TCGdex re-fetch on every cold start. New POST /api/card-database/sync (owner-only) compares cached set codes against TCGdex and only rebuilds when new sets are detected. Supports ?force=true to bypass the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lang(from stale Firestore cache) to"en"so the EN filter returns results instead of classifying all sets as JPTest plan
?lang=enreturns EN/both sets on production