feat: add lang filter to /api/sets#145
Merged
Merged
Conversation
Move eBay token + card DB init before app.listen so Cloud Run only routes traffic after data is ready. Eliminates the 503 window on cold start.
Tag cards with lang field at index build time. Sets get lang field (en, jp, both) based on card composition. /api/sets?lang=en returns sets with English cards, ?lang=jp for Japanese, no param for all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
langfield (enorjp) at index build timelangfield (en,jp, orboth) based on card composition/api/sets?lang=enreturns sets with EN cards,?lang=jpfor JP, omit for allTest plan
?lang=enfilter,?lang=jpfilter/api/sets?lang=enexcludes JP-only sets/api/sets?lang=jpexcludes EN-only sets