Skip to content

smbw: Course290_Main Bowser's Rage Stage 4:3 camera framing, autoscroll relays, and intro cutscene fix - #9

Merged
PyroDonkey merged 30 commits into
mainfrom
fix/bowsers-rage-zoom-extend
Nov 10, 2026
Merged

PyroDonkey merged 30 commits into
mainfrom
fix/bowsers-rage-zoom-extend

Conversation

@PyroDonkey

Copy link
Copy Markdown
Owner

Summary

Complete 4:3 adaptation for Bowser''s Rage Stage (Course290_Main), including opening giant fist zoom-out and extended zoom hold ($G = 18.5$), background smoke coverage extensions ($\pm 1.5$), autoscroll relay trigger retunings with 0 timing drift, Kuribo lightning strike and growth alignments, vertical shaft and rhythm pause camera framing, and intro cutscene camera pose Y raises to eliminate the handoff snap and conceal Bowser Jr. behind the letterbox bar.

Changes Included

  • Opening Fists Zoom & Extended Hold ($G = 18.5$):
    • Added dynamic zoom helper (A_HELPER) in gen_zoom_v2.py / 1.2.1.pchtxt setting $G = 18.5$ for fixed $X \le 100.0$, linearly lerping to $G = 15.75$ across $X \in [100.0, 112.0]$ (rail $X \in [87.67, 101.50]$) before Wall 0.
    • Symmetrically frames the giant knuckles ($X = 13.5$ and $X = 24.5$) with 73% width ratio and zero player collision push.
  • Background Smoke Planes Coverage:
    • Extended 4 background smoke actors (DVCommonTorideKemuriA / DVCommonTorideKemuriB) by $\pm 1.5$ in Y via build_stage.py, eliminating top and bottom visual voids during the fists and fossil sections.
  • Autoscroll Relay Triggers & Timing (0 Drift):
    • Shifted 7 relay switches during the $G = 18.5$ hold by $-2.89$ blocks in X, and lerp-transition switches by $-3.57$ and $-4.29$ blocks, preserving exact stock relay intervals and obstacle timing.
    • Added automated relay auditor audit_autoscroll_relays.py confirming 0 drift across all 47 switches.
  • Kuribo Strike & Growth Alignment:
    • Retuned spawn switch 578319643 ($X = 36.48$, frame 657) and zap switches 1536962149 / 14869113733391977869 ($X = 43.77$, frame 1040), preserving exact 383f relay interval.
    • Shifted Goomba spawns left by 3.5 blocks ($46.0 \to 42.5$, $50.0 \to 46.5$) to align walking Goombas to bolt strikes at tags $38.28125$ and $42.28125$.
  • Vertical Shaft & Post-Statue Rhythm Pause:
    • Shifted vertical shaft autoscroll rail points right by $+3.28$ blocks to center the 840-frame climb at $X = 138.78$.
    • Shifted statue-section triggers left by 6.56 blocks so EnemyTossinGroup spawns during the approach.
    • Shifted rhythm pause plateau and compressed pipes/plants by $+2.0$ blocks to frame singing plants and Spike thrower simultaneously with 1.0 block screen margin.
  • Intro Cutscene Camera Pose & Bowser Jr. Concealment (CourseDemo_PreFinalBattle.bfevfl):
    • Raised Event50 TargetYpos from $27.5 \to 28.75$ (commit dface15), matching 4:3 gameplay camera resting height ($19.5 + 9.25 = 28.75$) and eliminating the 1.25-block handoff snap (Bug A).
    • Raised Event26 TargetYpos from $27.5 \to 28.75$ (commit 2d4f07c), lifting the lower letterbox bar by 73 px and fully concealing Bowser Jr. ($y = 1079$, 44 px inside the $y \ge 1035$ letterbox bar) throughout the 4 knuckle slams (Bug B).
    • Preceding Event233 uses $Y = 29.0$, flattening the entire camera path across the latter half of the cutscene ($29.0 \to 28.75 \to 28.75$).
    • View top ($38.00$) stays safely below background smoke plane tops ($38.25$ and $38.35$) with zero top void exposure.
  • Tooling & Multi-Edit Support:
    • Updated build_stage.py with edits_by_flow() to support multi-edit EVENT_EDITS pipelines without file overwrites or verification issues.
    • Added unit test suite EventEditsTests in test_build_stage.py (18/18 tests passing).

Verification

  • check_repo: OK
  • test_build_stage: 18 tests passed (Ran 18 tests in 0.002s, OK)
  • build_stage --verify: 0 problem(s) reported across all BancMapUnit and EventFlow edits
  • verify_pchtxt: OK (304 patch lines, 11 hooks, 0 errors)
  • audit_autoscroll_relays: 0 drift/timing problem(s) detected across all 47 switches
  • release.py check smbw 1.1.2: checks passed
  • Mod files mirrored to Eden via robocopy /MIR

…smoke shifts to +-1.5

- Increase localized fist intro zoom from G = 17.5 to 18.5 (lerp back to 15.75 over fixed_X = 40..55) in Cave A free gap helper
- Scale DVCommonTorideKemuriA (+1.5) and B (-1.5) smoke Y shifts using shift = (G - 15.5)/2
- Vertical view range [18.00, 36.50] remains fully covered with zero void exposed
…oomba positions

- Retune spawn switch 578319643 to X = 37.025 (fires frame 744, restoring exact 383f relay interval to zap at frame 1127 under G = 18.5)
- Align strike PositionTags (40.28125, 44.28125) and BadSmokeTags (40.03125, 43.53125) to measured Goomba strike positions
- Full sequence verified: Goombas enter view (frames 1037 & 1083) -> lightning strikes directly overhead (frame 1127) -> growth in-frame (frame 1157)
- Update audit_autoscroll_relays.py camera model for G = 18.5 and verify 0 drift across all relays
Reverts f432b93. A probe with KoopaJrJumpFrame = 150 looked identical in Eden: Bowser Jr. lands near (25.6, 19.5) and stays until the cutscene ends, so the parameter does not control what is visible. Lesson recorded in DEVELOPMENT.md section 48.
The intro cutscene clamps to CameraArea 2220801104 (15.5 tall), so the 18.5-tall view was centred at y 27.25, then snapped up to the autoscroll's bottom-rest 28.75 (measured 1.25-1.5 blocks in Eden). Its lower edge (18.0) also showed Bowser Jr. parked at y ~19.5. Cave Y's other-area exit now goes to cave P (0x02138B60): in Course290_Main, upper Y limit = max(upper, lower). Built and verified; not yet played.
…h gameplay

CourseDemo_PreFinalBattle.bfevfl Event50 (the final cutscene camera pose before gameplay handoff) had TargetYpos 27.5 (stock 16:9 bottom rest was 27.25). In 4:3 with G=18.5, gameplay rests at y 28.75 (bottom 19.5 + half-height 9.25), causing a 1.25-block vertical snap at cutscene end.

Raising Event50 TargetYpos 27.5 -> 28.75 eliminates the vertical snap and lifts the cutscene bottom edge from 18.25 to 19.50. With the letterbox bar covering ~0.7 block (up to y 20.20), Bowser Jr. parked at y ~19.5..20.1 is fully concealed beneath the bar.
…-extend

# Conflicts:
#	.github/release-games.json
#	super-mario-bros-wonder/AGENTS.md
#	super-mario-bros-wonder/docs/DEVELOPMENT.md
#	super-mario-bros-wonder/tools/build_stage.py
@PyroDonkey
PyroDonkey merged commit f81c9c1 into main Nov 10, 2026
2 checks passed
PyroDonkey added a commit that referenced this pull request Nov 10, 2026
CHANGELOG v1.2.0 for PRs #9-#12; README What it changes and Known limits;
README.txt lists BancMapUnit/Event; AGENTS current state (Course290 and
Course853 confirmed in game, delete-first stage/event copy); three Common
bugs rows in the guide; DEVELOPMENT section 55 records the merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant