Repository navigation
smbw: fix Course853_Main (Pole Block Allure) camera framing and finale cannon trigger - #10
Merged
Merged
Conversation
…al framing Lower points 0-3 of autoscroll rail 1776580222928036096 in Y to keep the Wonder Flower and lower poles on-screen in 4:3 while maintaining vertical clearance.
…y 3.0 blocks Shifts ObjectBalloonKillerHodaiLeft from X = 251.5 to 248.5 so it enters the 4:3 camera view and fires its purple balloon creature when Mario approaches on the lower pole.
…ock cannon The finale cannon (ObjectBalloonKillerHodaiLeft, X 251.5, IsFirstInCamera) never fired in 4:3: rail X is the view's left edge, so the stock stop at X 226.75 frames [226.75, 247.75] and the cannon sits 3.75 blocks past the right edge. Move autoscroll rail 1776580222928036096 point 12 to X 231.335 (view [231.335, 252.335]) and drop the earlier 3.0-block cannon shift. The stop is measured from Eden captures: with the cannon body 0.335 blocks inside the right edge it fires, so 252.0 + 0.335 - 21.0 = 231.335. The pole's first 0.8 blocks fall off the left edge; pole start to cannon centre is exactly the 21.0-block 4:3 width. DEVELOPMENT.md section 45 corrects section 44's camera model (rail X is the left edge, rail Y the top edge). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…lock-allure # Conflicts: # super-mario-bros-wonder/docs/DEVELOPMENT.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two 4:3 problems in Sunbaked Desert Special: Pole Block Allure (
Course853_Main) by editing points of autoscroll rail1776580222928036096(RAIL_EDITSintools/build_stage.py). The net change againstmainis five rail points; no actors are moved.1. Vertical framing (points 0-3)
The stock climb (Y 17 -> 17 -> 25.5 -> 41) left the Wonder Flower at the bottom edge of the 4:3 view. Points 0-3 are lowered to Y 14.5, 14.5, 22.75, 36.0 (point 4 onwards unchanged). This retune was play-tested by the maintainer in Eden.
2. Finale cannon never fires (point 12)
DEVELOPMENT.mdsection 22). The stock final stop at X 226.75 frames [226.75, 247.75] in 4:3, so the green cannon (ObjectBalloonKillerHodaiLeft, X 251.5,IsFirstInCamera: True) is 3.75 blocks past the right edge and never starts firing. Moving Mario right only pans the view to about X 251.(226.75, 147.0, 0.0)->(231.335, 147.0, 0.0), view [231.335, 252.335]. The cannon stays at its stock position.InsideCameraMarginX) is not stored in its AI graph, so this observed margin is the reference.Docs
DEVELOPMENT.mdsection 44 described the rail point as the view centre, which is wrong; section 45 corrects it (rail X = left edge, rail Y = top edge) and records the measurements above.Verification
scripts/check_repo.py: OKbuild_stage.py --verify: 0 problems (Course853_Main: 7 byte(s) differ, all inside 5 edit(s))unittest: 16 tests passedverify_pchtxt.py: 0 errors56b85df2...): the finale cannon fires and the Wonder Seed is reachable.🤖 Generated with Claude Code