Repository navigation
🦀 C++ rewrite - #124
Draft
PyXiion wants to merge 67 commits into
Draft
🦀 C++ rewrite#124PyXiion wants to merge 67 commits into
PyXiion wants to merge 67 commits into
Conversation
… move Python to legacy/
…ants (clang-tidy readability-identifier-naming)
…he new conventions
…stants, metadata, startup impact parser)
…-mod text from parsed mods
… without WebSockets
…ivate every duplicate copy
…gs, retry index failures
…ci: pipx clang-tidy path; docs
…skip POSIX-only cases on Windows; ci: explicit tidy checks
…s, SQLite-only deploy
…_scale is invalid; merge ui_scale on save
Behavior-preserving cleanup across core and UI: - core/services: drop unused StartupImpact API and report helpers, the SidebarBase cache, GameLauncher injection knobs, parseVersion and forwarding wrappers. - core/organizer, sort: drop test-only tier cycle helpers, merge Rule into RuleSpec, single OrganizerService ctor path, dedupe tier closure, folder walks and DB checks. - core/checker, models, providers: one CachedDatabase template, one FolderModProvider, shared discover(); drop the test-only incremental checker API, write-only issue fields and dead schema types. - core/workshop, downloads: downloaders notify DownloadManager directly, single WorkshopCatalog ctor, drop unused plan/batch fields. - core root, app: drop AppConfigService, UiPrefsService, test-only XML writer, computeStats, the never-called initialize/snapshot chain and the PX_SMOKE_EXIT_MS hook; appVersion comes from PROJECT_VERSION. - ui: delete unused ProgressDialog, AspectRatioBanner, IconButton, AppButton, Main.qml, dead QSS and signal relays; split organizer editFolder/mutateTag string dispatch into named coroutines; dedupe repeated QML blocks.
…patibilities and dead test scaffolding
…l updates Community rules are optional data: a bad file warns and clears previous rules instead of failing the mod load, and an asynchronous startup failure now ends the event loop. Auto-sort sorts from an owned snapshot and drops stale results instead of touching live checker state from a worker thread. Workshop cards use typed card data, the mod info panel refreshes per cause, providers take the metadata cache only per discovery, and the organizer tree model takes tree ownership. The Workshop backend shares the catalog Steam transport and no longer turns failures into crawl completion.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const auto pathParts = path.split(u'/', Qt::SkipEmptyParts); | ||
| const auto directoryParts = directory.split(u'/', Qt::SkipEmptyParts); | ||
| return pathParts.size() > directoryParts.size() && | ||
| std::equal(directoryParts.begin(), directoryParts.end(), |
| return Response.json({ response: { total: 1, publishedfiledetails: [{ publishedfileid: '601' }], next_cursor: 'page-2' } }); | ||
| } | ||
| assert.ok(url.pathname.includes('GetDetails'), `Unexpected Steam method ${url.pathname}`); | ||
| const input = JSON.parse(url.searchParams.get('input_json')!) as { publishedfileids: string[] } & Record<string, unknown>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings, PyXiion! The silicon-based contributor is here.
Draft PR opened only to trigger CI (ci.yml runs on pull_requests to main) for the cpp-rewrite branch.