Skip to content

handle non-directories in sys.path#23

Merged
messense merged 6 commits into
PyO3:mainfrom
mbway:issue_21
Jun 8, 2025
Merged

handle non-directories in sys.path#23
messense merged 6 commits into
PyO3:mainfrom
mbway:issue_21

Conversation

@mbway
Copy link
Copy Markdown
Collaborator

@mbway mbway commented Jun 6, 2025

fixes #21

Initially I thought that the issue was related to site-wide installation so I refactored the wrapper around uv/pip to allow for more easily writing tests that create new virtualenvs but in the end the issue can be replicated without a site-wide installation.

@mbway
Copy link
Copy Markdown
Collaborator Author

mbway commented Jun 6, 2025

proof that the new test triggers the error and is the only failure: https://github.com/mbway/maturin-import-hook/actions/runs/15506970254/job/43663031104

@mbway mbway marked this pull request as ready for review June 7, 2025 10:43
@mbway mbway requested a review from messense June 7, 2025 10:44
@mbway mbway added the CI-test-all Test on every supported platform label Jun 7, 2025
@messense messense merged commit 0b99754 into PyO3:main Jun 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-test-all Test on every supported platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installing maturin_import_hook causes the binary file from pip to fail on Windows.

2 participants