Skip to content

Add range validation to binary Writer #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickwierenga wants to merge 2 commits into from
Closed

Add range validation to binary Writer #911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf7bea6
Add range validation to binary Writer integer methods
rickwierenga Feb 28, 2026
fe0d9cd
Restore docstrings and use derivations instead of magic numbers
rickwierenga Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pylabrobot/io/binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,41 +32,57 @@ def __init__(self, little_endian: bool = True):

def u8(self, value: int) -> "Writer":
"""Write unsigned 8-bit integer (0-255)."""
if not 0 <= value <= 0xFF:
raise ValueError(f"u8 requires 0 <= value <= {0xFF}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}B", value))
return self

def u16(self, value: int) -> "Writer":
"""Write unsigned 16-bit integer."""
if not 0 <= value <= 0xFFFF:
raise ValueError(f"u16 requires 0 <= value <= {0xFFFF}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}H", value))
return self

def u32(self, value: int) -> "Writer":
"""Write unsigned 32-bit integer."""
if not 0 <= value <= (1 << 32) - 1:
raise ValueError(f"u32 requires 0 <= value <= {(1 << 32) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}I", value))
return self

def u64(self, value: int) -> "Writer":
"""Write unsigned 64-bit integer."""
if not 0 <= value <= (1 << 64) - 1:
raise ValueError(f"u64 requires 0 <= value <= {(1 << 64) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}Q", value))
return self

def i8(self, value: int) -> "Writer":
"""Write signed 8-bit integer (-128 to 127)."""
if not -(1 << 7) <= value <= (1 << 7) - 1:
raise ValueError(f"i8 requires {-(1 << 7)} <= value <= {(1 << 7) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}b", value))
return self

def i16(self, value: int) -> "Writer":
"""Write signed 16-bit integer."""
if not -(1 << 15) <= value <= (1 << 15) - 1:
raise ValueError(f"i16 requires {-(1 << 15)} <= value <= {(1 << 15) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}h", value))
return self

def i32(self, value: int) -> "Writer":
"""Write signed 32-bit integer."""
if not -(1 << 31) <= value <= (1 << 31) - 1:
raise ValueError(f"i32 requires {-(1 << 31)} <= value <= {(1 << 31) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}i", value))
return self

def i64(self, value: int) -> "Writer":
"""Write signed 64-bit integer."""
if not -(1 << 63) <= value <= (1 << 63) - 1:
raise ValueError(f"i64 requires {-(1 << 63)} <= value <= {(1 << 63) - 1}, got {value}")
self._buffer.write(struct.pack(f"{self._endian}q", value))
return self

Expand Down