Skip to content

Define how Select opens, closes and boxes - #88

Merged
pfsteve merged 2 commits into
mainfrom
feat/select-tool
Nov 7, 2026
Merged

pfsteve merged 2 commits into
mainfrom
feat/select-tool

Conversation

@pfsteve

@pfsteve pfsteve commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Builds on #87, which also changes the Select tool, so this PR targets that branch. GitHub retargets it to main once #87 merges.

Changes

  • Click outside an open group: closes groups out to the one that holds what was clicked, then selects it there. It no longer leaves a selection outside the group being edited.
  • Esc: clears the selection first, and with nothing selected closes one level of the open group.
  • Enter: opens the one selected group or component.
  • Locked groups: a double-click or Enter selects a locked group or component instead of failing silently, and the status bar says it's locked.
  • Selection box and Lasso: they now take every visible kind in the open context, adding mesh parts, guides, dimensions, leader text and section planes to geometry, groups, components and images.
    • A guide line has no end, so only a crossing box takes it.
    • Screen text isn't boxed.
    • A group or component is judged by its mesh parts as well.
  • Select All and Invert Selection: they take images, dimensions, text and section planes too. They skip anything hidden or on a hidden tag unless hidden geometry is shown, and skip guides and section planes while their display is off.

docs/help/modeling/selection.md has new sections on the Select tool and on opening and closing groups.

Testing

Typecheck, lint, the SPDX check and the full suite pass (4,563 tests). New tests cover clicking outside an open group, the Esc order, Enter, a locked group, box selection of guides, leader text and section planes, and Select All and Invert with hidden entities. Not yet checked by hand in the running app.

🤖 Generated with Claude Code

- A click on something outside the open group closes groups out to the one
  that holds it, then selects it there.
- Esc clears the selection first; with nothing selected it closes one level.
- Enter opens the one selected group or component.
- A locked group or component is selected instead of opened, and the status
  bar says it is locked.
- A selection box and Lasso now take every visible kind in the open context:
  mesh parts, guides, dimensions, leader text and section planes as well as
  geometry, groups, components and images. An endless guide line is taken
  only by a crossing box. Groups are judged by their mesh parts too.
- Select All and Invert Selection take images, dimensions, text and section
  planes too, and skip what is hidden or on a hidden tag unless hidden
  geometry is shown.

The selection help has new sections for the Select tool and for opening
and closing groups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from fix/tool-bugs to main November 7, 2026 15:25
@pfsteve
pfsteve enabled auto-merge November 7, 2026 15:26
@pfsteve
pfsteve merged commit e09a602 into main Nov 7, 2026
11 checks passed
@pfsteve
pfsteve deleted the feat/select-tool branch November 7, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant