Iannotate demo#228
Open
4xdk wants to merge 7 commits into
Open
Conversation
elimisteve
reviewed
Jul 14, 2018
| hypothesisData.links.html + | ||
| ' "' + | ||
| hypothesisData.name + | ||
| '")') |
Contributor
There was a problem hiding this comment.
Use backticks here: "* Hypothesis Group: ${hypothesisData.name} ... "
Collaborator
Author
There was a problem hiding this comment.
linter is still splitting this in a weird way, now it's just one place though.
Any way we can prevent it from splitting it like:
deliverables: (task.deliverables +=* Hypothesis Group: ${
hypothesisData.name
})
elimisteve
reviewed
Jul 14, 2018
| accept: 'application/json', | ||
| 'content-type': 'application/json', | ||
| authorization: 'Bearer 6879-DF1aRxrzWAarRZBMfak86Zs57i-LFtZCF1esFLYIlAU' // TODO update to one owned by elimisteve | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
Yeah, that was the toughest bit :)
elimisteve
reviewed
Jul 26, 2018
| // taskGid, | ||
| // name, | ||
| // description, | ||
| // }) |
elimisteve
reviewed
Jul 26, 2018
| headers: { | ||
| accept: 'application/json', | ||
| 'content-type': 'application/json', | ||
| authorization: 'Bearer 6879-DF1aRxrzWAarRZBMfak86Zs57i-LFtZCF1esFLYIlAU' // TODO update to one owned by elimisteve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the note at: https://github.com/PursuanceProject/pursuance/compare/iannotate-demo...4xdk:iannotate-demo?expand=1#diff-4e3037116dbc2bc69a473b7ace3d02abR264