Skip to content

Storage type for pubmatic id#592

Open
pm-nitin-shirsat wants to merge 2 commits into
nightlyfrom
pubmatic_uid_storage_type
Open

Storage type for pubmatic id#592
pm-nitin-shirsat wants to merge 2 commits into
nightlyfrom
pubmatic_uid_storage_type

Conversation

@pm-nitin-shirsat
Copy link
Copy Markdown

No description provided.

Comment thread src_new/common.config.js
"source": [
"esp.pubmatic.com"
],
"encrypt": false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 6 tabs but found 12 spaces.

Suggested change
"encrypt": false
"encrypt": false

Comment thread src_new/common.config.js
"userSync": {
"encryptedSignalSources": {
"sources": [
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 5 tabs but found 10 spaces.

Suggested change
{
{

Comment thread src_new/common.config.js
exports.getEncryptedSignalSourcesConfig = function () {
var idHubPartners = CONFIG.getIdentityPartners();
if (!CONFIG.isUserIdModuleEnabled() || !idHubPartners || !idHubPartners.pubmaticId) {
return null;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change
return null;
return null;

Comment thread src_new/common.config.js
};

exports.getEncryptedSignalSourcesConfig = function () {
var idHubPartners = CONFIG.getIdentityPartners();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
var idHubPartners = CONFIG.getIdentityPartners();
var idHubPartners = CONFIG.getIdentityPartners();

Comment thread src_new/common.config.js
}
return {
"userSync": {
"encryptedSignalSources": {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 3 tabs but found 6 spaces.

Suggested change
"encryptedSignalSources": {
"encryptedSignalSources": {

Comment thread src_new/common.config.js
"encrypt": false
}
],
"registerDelay": 3000
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change
"registerDelay": 3000
"registerDelay": 3000

Comment thread src_new/common.config.js
if (!CONFIG.isUserIdModuleEnabled() || !idHubPartners || !idHubPartners.pubmaticId) {
return null;
}
return {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
return {
return {

Comment thread src_new/common.config.js
return {
"userSync": {
"encryptedSignalSources": {
"sources": [
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change
"sources": [
"sources": [

Comment thread src_new/common.config.js
return null;
}
return {
"userSync": {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change
"userSync": {
"userSync": {

Comment thread src_new/common.config.js

exports.getEncryptedSignalSourcesConfig = function () {
var idHubPartners = CONFIG.getIdentityPartners();
if (!CONFIG.isUserIdModuleEnabled() || !idHubPartners || !idHubPartners.pubmaticId) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
if (!CONFIG.isUserIdModuleEnabled() || !idHubPartners || !idHubPartners.pubmaticId) {
if (!CONFIG.isUserIdModuleEnabled() || !idHubPartners || !idHubPartners.pubmaticId) {

Comment thread src_new/common.config.js
{
"source": [
"esp.pubmatic.com"
],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 6 tabs but found 12 spaces.

Suggested change
],
],

Comment thread src_new/common.config.js
"sources": [
{
"source": [
"esp.pubmatic.com"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 7 tabs but found 14 spaces.

Suggested change
"esp.pubmatic.com"
"esp.pubmatic.com"

'setConfig': function(){},
'onSSOLogin': function onSSOLogin() {},
'requestBids': function(){},
'mergeConfig': function(){},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
'mergeConfig': function(){},
"mergeConfig": function(){},

Comment thread src_new/common.config.js
"encryptedSignalSources": {
"sources": [
{
"source": [
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 6 tabs but found 12 spaces.

Suggested change
"source": [
"source": [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant