Repository navigation
Show channel counts and verified speaker layouts in Song Info - #1867
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1843.
5.1,6.0or4.0. Layout is never guessed from the number of channels.Implementation and compatibility
channelLayoutobject to the existingaudio:formatpayload:mainChannels,lfeChannelsand an explicit provenance. No commands/events are renamed or removed; existing channel counts and playback identity fields remain intact.Validation
Independent frontend and native reviews found no remaining correctness blockers. Regression coverage includes metadata/count fallback, exact-generation redelivery, owner/canonical-key matching, original-versus-transcoded provenance, closed-modal render commits, parser limits, transparent source I/O and buffered/streaming constructor behavior.
Final frontend gates all passed:
npm run lint,npm run dep:check,npm test(893 suites / 7170 tests),npm run prebuild:release-notes,npx tsc --noEmit, Vitest coverage and the frontend hot-path coverage gate (15 files, none below threshold). Commands ran inside the Nix development environment.Native workspace tests: 2631 passed, 0 failed, 19 ignored. Workspace Clippy (
-D warnings) passed.Runtime benchmark
Manual verification
5.1.Real-webview visual checks and full compressed Vorbis fixture integration were not performed in this session. Native FLAC and synthetic extensible WAV constructor paths are covered by tests.