docs: scope the architecture diagram to the operator path - #87
Open
renecannao wants to merge 1 commit into
Open
Conversation
The "Architecture at a glance" diagram sits immediately below a table advertising three Helm charts, so it reads as if it explains all of them. It does not: it shows only the operator path — ProxySQLCluster reconciling into a StatefulSet/Services/Secrets/PDB, and ProxySQLConfig pushing SQL to the admin port. Neither standalone chart has a CRD, a controller, or a SQL push anywhere in it. Retitled the section and added two clarifications underneath: - the diagram is the operator path only; the standalone charts render proxysql.cnf from their Helm values into a ConfigMap (charts/proxysql) or a Secret (charts/proxysql-cluster), which ProxySQL reads on first start - the SQL push targets every replica rather than one, with a link to the existing rationale in docs/architecture.md Everything asserted here was checked against the code rather than the prose: charts/proxysql/templates/configmap.yaml is a ConfigMap carrying proxysql.cnf; charts/proxysql-cluster/templates/secret-cnf.yaml is a Secret carrying the same key (its own header explains the difference — the rendered cnf embeds the admin/radmin/ monitor passwords); neither standalone chart passes --reload, unlike the operator's statefulset builder, so "read on first start" holds for them; and proxysqlcluster_controller_test.go asserts that replicas=3 populates proxysql_servers, confirming cluster sync is enabled as a backstop while the operator still writes to all. Reported by a reader who hit exactly this ambiguity. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe README now distinguishes the operator reconciliation path from standalone chart deployments. It documents standalone configuration rendering, direct SQL writes to replicas, cluster-sync fallback, and the related design rationale. ChangesArchitecture documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Architecture at a glance diagram sits directly under the table advertising three Helm charts, so it reads as though it explains all three. It does not — it shows only the operator path:
ProxySQLClusterreconciling into a StatefulSet, Services, Secrets and a PDBProxySQLConfigpushing SQL to the admin portNeither standalone chart has a CRD, a controller, or a SQL push anywhere in it, so a reader following the table into the diagram comes away with the wrong model of
charts/proxysqlandcharts/proxysql-cluster.What this changes
Docs only — one file, +14/−1. No code, charts or CRDs touched.
proxysql.cnffrom their Helm values into aConfigMap(charts/proxysql) or aSecret(charts/proxysql-cluster), read on first startdocs/architecture.mdVerification
Each claim was checked against the code rather than the prose:
charts/proxysqluses a ConfigMapcharts/proxysql/templates/configmap.yaml—kind: ConfigMap, keyproxysql.cnfcharts/proxysql-clusteruses a Secretcharts/proxysql-cluster/templates/secret-cnf.yaml—kind: Secret, same key; its own header notes the rendered cnf embeds the admin/radmin/monitor passwords--reload, unlikeoperator/internal/controller/builders/statefulset.go:357proxysqlcluster_controller_test.go:142assertsreplicas=3populatesproxysql_servers, while the operator still writes to allThe two standalone charts genuinely differ from each other here — ConfigMap vs Secret — which is easy to flatten into "a ConfigMap" if writing from memory.
Why
Raised by a reader who hit exactly this ambiguity: having read the three-chart table, they expected the diagram to cover all three and asked what it actually referred to.
🤖 Generated with Claude Code
Summary by CodeRabbit