Repository navigation
Preserve reference texture colors during resolution upgrades - #141
Merged
Protonmatter merged 1 commit intoNov 14, 2026
Conversation
Protonmatter
marked this pull request as ready for review
November 14, 2026 06:24
Protonmatter
merged commit Nov 14, 2026
b7aed0b
into
precision/verified-readiness-20261109
22 checks passed
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fix the P2 found during review of #137: zooming or enlarging a registered Earth/Moon surface could darken it while a higher-resolution map loaded. The upgrade retained the existing SRGB8_ALPHA8 texture but dropped its linearFilter flag, causing the shader to decode linear samples again.
Preserve the retained texture's color metadata until replacement succeeds or fails.
Specification and traceability
Correctness and risk
One production-state field is retained alongside the existing texture. Initial loads, successful replacement, and failed-upgrade fallback keep their existing behavior. No migration, dependency, privacy, or source-provenance changes. Revert this commit if needed. Targets precision; #137 remains the separate publishing decision.
UI and UX
Reference imagery keeps consistent brightness while a larger variant is pending. Controls, keyboard/focus, touch, layout, and error messaging are unchanged.
Validation evidence
Documentation
Existing user help and rendering contracts remain accurate; no new behavior or release claim introduced.