Skip to content

Preserve reference texture colors during resolution upgrades - #141

Merged
Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/preserve-texture-upgrade-color
Nov 14, 2026
Merged

Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/preserve-texture-upgrade-color

Conversation

@Protonmatter

Copy link
Copy Markdown
Owner

Outcome

Fix the P2 found during review of #137: zooming or enlarging a registered Earth/Moon surface could darken it while a higher-resolution map loaded. The upgrade retained the existing SRGB8_ALPHA8 texture but dropped its linearFilter flag, causing the shader to decode linear samples again.

Preserve the retained texture's color metadata until replacement succeeds or fails.

Specification and traceability

  • Requirements: SOL-VIS-001, SOL-TEST-001.
  • Governing specification: Existing display-color and reference-image loading contracts.
  • RFC/ADR: No new decision; corrective state preservation.
  • Non-goals: Shader math, source pixels, scientific calibration, loading budgets.

Correctness and risk

One production-state field is retained alongside the existing texture. Initial loads, successful replacement, and failed-upgrade fallback keep their existing behavior. No migration, dependency, privacy, or source-provenance changes. Revert this commit if needed. Targets precision; #137 remains the separate publishing decision.

UI and UX

Reference imagery keeps consistent brightness while a larger variant is pending. Controls, keyboard/focus, touch, layout, and error messaging are unchanged.

Validation evidence

  • Expanded the existing upgrade test to inspect the actual bound texture and shader uniform before, during, and after successful/failed upgrades.
  • Both cases failed before the fix with u_textureLinear=0 instead of 1; passed after.
  • Added distinct RGBA/SRGB8_ALPHA8 constants to the existing WebGL harness so its upload-format assertion is meaningful.
  • Independent reviewer confirmed the fix and test coverage; no remaining findings.
  • npm test: 2,298 passed, zero failures on final tree.
  • python tools/typecheck_web.py: 152 files clean.
  • python tools/validate_sdlc.py and git diff --check: passed.
  • Full hosted CI/coverage and packaged browser gates pending. Native-GPU testing not performed.

Documentation

Existing user help and rendering contracts remain accurate; no new behavior or release claim introduced.

@Protonmatter
Protonmatter marked this pull request as ready for review November 14, 2026 06:24
@Protonmatter
Protonmatter merged commit b7aed0b into precision/verified-readiness-20261109 Nov 14, 2026
22 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T06:25:05.614262Z f220e01 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant