Repository navigation
Close leftover #135 review findings, three baseline review findings, and record the precision work - #138
Merged
Protonmatter merged 8 commits intoNov 12, 2026
Conversation
…very Two parts of the #135 review of the display-resolution controller were still open. A fresh controller could lower resolution about 340 ms after the first frame, because lastChange started at -Infinity and only two warm-up frames were skipped. First frames share the main thread with shader compilation, texture decode and engine start-up, so that evidence describes loading. Slow frames in the three seconds after the first rendered Auto frame no longer count as overload. A device that stays slow is lowered just after the window, and returning to Auto later does not reopen it. A paused scene only draws while the pointer moves. Recovery needed 180 consecutive fast input frames with no gap over 250 ms, about three seconds of unbroken dragging, because every idle gap discarded the headroom count. The count now survives an idle gap between input bursts. Any slow frame still clears it, a resumed animation still restarts the assessment, and idle observations still cannot certify recovery. The integration test that expected a drop within half a second of the first frame now asserts both halves: no drop inside the window, the same drop after it.
The #135 review noted that the receipt recorded a constant profile and that read_receipt accepted Cargo's plain release profile for any sources. validate_receipt already rejected it for current sources, but the post-build manifest validator uses read_receipt alone, so a hand-made release receipt for a size-optimized build passed there. build_wasm.py now selects the Cargo profile and records the receipt from one name, and write_receipt refuses any profile other than wasm-release. read_receipt accepts the release profile only when the recorded root Cargo.toml digest is the one manifest that predates the browser profile (unchanged from master through 02aaec8). No published release carries a release receipt: the live release was built before receipts existed.
CHANGELOG.md had no entry for the precision branch. Add upgrade notes (ephemeris-snapshot.v4, updating a self-hosted server together with the web app, the solar-ephemeris API break that requires 0.3.0 at the next crates.io publish, the wasm-release profile) and the user-visible changes. The workspace version stays 0.2.0. Both engines stamp it into snapshots, the committed research data bundle and hash-bound evidence fixtures, so the bump belongs with the change that publishes the crate. docs/structural-remediation.md and its plan cited evidence under /workspace/sol-review and build/, which are local to the authoring workstation. Say so, and list what can be checked from the repository and CI. The 16 ms raw-position assertion lives in a tool no CI workflow runs, so that figure is recorded as a local result. Add an upgrade section to the ephemeris server README.
A browser keeps a failed module fetch for the life of its document, so "Retry this view" and "Retry catalogue downloads" re-imported the same URL and failed again without touching the network. Only a manual page reload recovered, even after the connection returned. A retry still re-imports first, which is all a timed-out import needs. If that explicit retry is rejected a second time, the loader asks whether the module is reachable now (a no-store fetch of the same URLs). When it is, the page reloads; the saved surface brings the visitor back to the same view. When it is not, the page and the visible failure stay exactly as they were, so an offline visitor is never reloaded into a blank page. Only the Retry buttons opt in. Selecting a view again, returning to the tab and demand-driven catalogue loads never replace the document. Confirmed in Chromium against a staged /sol/ build: a first-time visitor with the Solar System code failing, and a service-worker-controlled visitor with the moon catalogue failing. In both, Retry keeps the error while the file is unavailable and recovers once it is reachable. The startup descriptor is regenerated for the three changed startup modules. Two app fixtures gain a stub recovery factory.
validate_release_manifest.py checked the WASM build receipt, the source manifest and the source archive only when the artifact happened to list them. A build that stopped staging one of them still passed both deploy validations, and the archive was never compared with the size and hash its own source manifest publishes. An artifact that carries the ephemeris component portal, or that speaks an ephemeris contract newer than v3, must now list the portal page, the receipt, the source manifest and the archive. The archive's size and SHA-256 must match the source manifest. A portal-less v2 or v3 shell is still valid, but may not stage half a source distribution. Confirmed against a real staged site: removing the receipt, removing the source manifest, and replacing the archive with junk (outer manifest rehashed each time) all fail now and all passed before. The live release (v3, no portal) still validates. The release fixture now stages a stand-in distribution with the real shape instead of none, so the existing portal tests exercise the rule.
Every captured Horizons pointing fixture was from 2026, where DUT1 is below 0.08 s and moves the sky by about one arcsecond, inside the 10 and 12 arcsecond budgets. Dropping DUT1 from UT1 left the whole Rust suite green while giving about 11 arcseconds of altitude/azimuth error for 1973 dates. Add 12 retained JPL Horizons replies for the Sun, Moon and Jupiter at two sites on 1973-01-15 (DUT1 +0.763 s) and 2015-06-20 (DUT1 -0.669 s), in the existing reference-pack format with request URLs, hashes and the acquisition helper. An integration test drives the public sky_snapshot_json and holds altitude/azimuth and RA/Dec to 2 arcseconds and DUT1 to 3 ms. The worst measured residual is 0.45 arcseconds. Three mutations now fail the suite: UT1 without DUT1, UT1 with DUT1 reversed, and a correct reported UT1 with the rotation angle taken from UTC (10.99 arcseconds against the 2 arcsecond budget). A second test asserts that the cohort keeps large DUT1 of both signs and that the budget stays below a quarter of the displacement a dropped DUT1 causes. The test lives under tests/ and uses only the public API, so no source file bound by the independent accuracy evidence changes.
Protonmatter
marked this pull request as ready for review
November 12, 2026 07:01
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Protonmatter
merged commit Nov 12, 2026
f21b5a2
into
precision/verified-readiness-20261109
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Closes the review findings from #135 that were only partly addressed, fixes three findings from the review of the unreviewed baseline commit, and adds the release housekeeping that #137 (precision to
master) was missing. Merging this into the precision branch updates #137.From the #135 review:
releaseprofile for any sources. After this change that profile is readable only for the one root manifest that predates the browser profile, andwrite_receiptrefuses any profile other than the onebuild_wasm.pyrequested.From the baseline review:
validate_release_manifest.pypasses a component release whose WASM receipt, source manifest or source archive is missing, and never compares the archive with its source manifest. After this change those files are required and the archive must match the size and SHA-256 its source manifest publishes.Housekeeping:
CHANGELOG.mdhad no entry for the precision branch.docs/structural-remediation.mdcited evidence under/workspace/sol-reviewandbuild/, which are not in the repository. The report now says so and lists what can be checked from the repository and CI.Specification and traceability
docs/structural-remediation.md,docs/WASM_SOURCE_BINDING_20261108.md,tests/fixtures/horizons-observer-dut1-20261112/README.mdsourcespaths (Address structural rendering, loading, and ephemeris weaknesses #135 review). NosourceMappingURLis emitted and sources are embedded, so nothing fetches those paths.Correctness and risk
renderQuality.js: the start-up window opens at the first rendered Auto frame and lasts 3 s. Only overload evidence is ignored inside it. Headroom gathered by a paused scene survives an idle gap between input bursts; any slow frame clears it.catalogueLoader.js,viewLoader.js: a retry re-imports first. Only an explicit Retry click, after a second rejection, probes the module URLs with ano-storefetch and reloads when every one responds. Selecting a view again, returning to the tab and demand-driven catalogue loads never reload. A timed-out import is not a rejection and never reloads.wasm_provenance.py:read_receiptraises for areleasereceipt whoseCargo.tomldigest is not the pinned pre-profile manifest.write_receiptraises, and writes nothing, for any profile other thanwasm-release.validate_release_manifest.py: an artifact that carries the ephemeris component portal, or speaks an ephemeris contract newer than v3, must list the portal page, the receipt, the source manifest and the archive. A portal-less v2 or v3 shell stays valid but may not stage half a source distribution.releasereceipt. Local build directories from before this change need a rebuild withtools/build_wasm.py.tests/and uses only the public API, so no source file bound by the independent accuracy evidence changes.UI and UX
Validation evidence
Commands and results:
Mutation and negative checks:
Browser checks in Chromium against a staged
/sol/build:Documentation