Make errors stack traces of createPacketBuffer readable#155
Open
zardoy wants to merge 2 commits intoProtoDef-io:masterfrom
Open
Make errors stack traces of createPacketBuffer readable#155zardoy wants to merge 2 commits intoProtoDef-io:masterfrom
zardoy wants to merge 2 commits intoProtoDef-io:masterfrom
Conversation
Member
|
Please provide some examples of errors with the new code The TryCatch part applies to lot of places |
Author
@rom1504 these are not useful, however if it could also log the packet at the same time, the issue would become very obvious: please consider this, IMO its better rather than not providing any additional info (right now there is no way to get the packet from the exception at all) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some error reporting tools like Sentry already do increase stack trace limit, but I think it would be good to make this default behavior. example stack trace with the extended limit:
If you don't like the idea of increasing the stack trace consider at least adding the packet to the message that caused the problem