Conversation
rom1504
reviewed
Dec 8, 2024
package.json
Outdated
| "description": "Validate ProtoDef protocol definition in node", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "prepare": "git submodule update --init", |
Member
There was a problem hiding this comment.
Why do we need this? We don't have it in https://github.com/PrismarineJS/node-minecraft-data/blob/master/package.json
Contributor
Author
There was a problem hiding this comment.
By default git doesn't checkout the submodules without cloning repo recursively (github CI does this but not codespaces/gitpod), so you have to clone it manually after by running that. Adding to prepare just adds an extra command run after a local npm install which can init the submodules. But it's not needed though, just removed it.
Member
|
Hmm we don't have the release action here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #12