Skip to content

Fix GraphQL typing bug - #87

Open
cvauclair wants to merge 2 commits into
mainfrom
bugfix/84
Open

cvauclair wants to merge 2 commits into
mainfrom
bugfix/84

Conversation

@cvauclair

Copy link
Copy Markdown
Contributor

Eval:
-Fix bug where, due to different ordering of record fields between a
GraphQL query's type signature and its response data, the function
gql_to_value would raise an exception (closes #84)

Eval:
-Fix bug where, due to different ordering of record fields between a
GraphQL query's type signature and its response data, the function
`gql_to_value` would raise an exception (closes #84)
@cvauclair cvauclair added bug Something isn't working mesh:core Mesh Language core feature labels Oct 26, 2021
@cvauclair

Copy link
Copy Markdown
Contributor Author

@ThierryBleau can you try this branch with your previous queries to confirm that the bug is fixed?

@ThierryBleau

Copy link
Copy Markdown
Collaborator

I just need to build and replace the kernel spec right?

@ThierryBleau

Copy link
Copy Markdown
Collaborator

Still doesnt work for this one

Graphql.execute(```graphql(https://api.thegraph.com/subgraphs/name/convex-community/convex-votium)
      query {
        bribes {
            id
            epoch {
                id
            }
            token
            amount
        }
    }
```);

@cvauclair

cvauclair commented Oct 26, 2021 •

Copy link
Copy Markdown
Contributor Author

The issue with the Convex query seems to come from the Graphql_ppx (which we use to validate a query against a schema); the following exception is thrown:
Graphql_ppx_base__Option.Option_unwrap_error("Cannot read config")

@ThierryBleau can you test more subgraphs to see if this is isolated to the Convex subgrpah or not? If it is, then I think the bug is not as critical and we can merge, but if it is widespread, then I'll have to do more digging

@ThierryBleau

Copy link
Copy Markdown
Collaborator

There is also this one

Graphql.execute(```graphql(https://api.thegraph.com/subgraphs/name/drondin/olympus-graph)
      query {
        dailyBonds(orderBy: timestamp, orderDirection: desc) {
            amount
            timestamp
            amount
            token {
              id
            }
        }
      }
```);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mesh:core Mesh Language core feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Queyring subgraph runs forever but is instant on thegraph playground

2 participants