Conversation
Eval: -Fix bug where, due to different ordering of record fields between a GraphQL query's type signature and its response data, the function `gql_to_value` would raise an exception (closes #84)
Contributor
Author
|
@ThierryBleau can you try this branch with your previous queries to confirm that the bug is fixed? |
Collaborator
|
I just need to build and replace the kernel spec right? |
Collaborator
|
Still doesnt work for this one |
Contributor
Author
|
The issue with the Convex query seems to come from the Graphql_ppx (which we use to validate a query against a schema); the following exception is thrown: @ThierryBleau can you test more subgraphs to see if this is isolated to the Convex subgrpah or not? If it is, then I think the bug is not as critical and we can merge, but if it is widespread, then I'll have to do more digging |
Collaborator
|
There is also this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eval:
-Fix bug where, due to different ordering of record fields between a
GraphQL query's type signature and its response data, the function
gql_to_valuewould raise an exception (closes #84)