refactor: rename sketchlib-rust to asap_sketchlib#266
Open
Conversation
The sketchlib-rust repository (ProjectASAP/sketchlib-rust) has been renamed to asap_sketchlib (ProjectASAP/asap_sketchlib) and its Cargo package name changed from "sketchlib-rust" to "asap_sketchlib". Update all references across the codebase: - Cargo.toml dependency declarations (asap-query-engine, sketch-core) - Rust source imports (use sketchlib_rust:: → use asap_sketchlib::) - UDF Jinja templates (5 files in asap-summary-ingest) - Doc comments, Dockerfile comments, deployment docs, benchmark report - Regenerate Cargo.lock Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
rename-sketchlib-rust-to-asap-sketchlib
branch
from
02f9e4a to
3abec84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sketchlib-rustrepo has been renamed toasap_sketchlib(ProjectASAP/asap_sketchlib) and its Cargo package changed fromsketchlib-rusttoasap_sketchlibasap-summary-ingestpipeline build failure caused by Cargo not finding thesketchlib-rustpackage in the renamed repoChanges
sketchlib-rust = { git = ".../sketchlib-rust" }→asap_sketchlib = { git = ".../asap_sketchlib" }use sketchlib_rust::→use asap_sketchlib::Test plan
cargo check --workspacecompiles successfullycargo test -p sketch-corepassescargo clippy --workspacepasses🤖 Generated with Claude Code