Add accuracy/performance CI and benchmarks infrastructure#248
Merged
milindsrivastava1997 merged 3 commits intomainfrom Apr 2, 2026
Merged
Add accuracy/performance CI and benchmarks infrastructure#248milindsrivastava1997 merged 3 commits intomainfrom
milindsrivastava1997 merged 3 commits intomainfrom
Conversation
- accuracy_performance.yml: full e2e eval — builds ASAP service images once (planner-rs, summary-ingest, query-engine) with sha tag, spins up quickstart stack, waits for Arroyo pipeline + sketch ingestion, runs PromQL suite against Prometheus (baseline) and ASAPQuery, then compares accuracy and latency - benchmarks/docker-compose.yml: compose override replacing GHCR images with ASAP_IMAGE_TAG so CI tests latest committed code - benchmarks/queries/promql_suite.json: 14-query fixed suite covering avg/sum/max/min/quantile at p50/p90/p95/p99 with/without grouping - benchmarks/scripts/: compare.py, run_baseline.py, run_asap.py, wait_for_stack.sh, ingest_wait.sh - asap-summary-ingest/Dockerfile: switch FROM to ghcr.io base image so builds work without a local sketchdb-base image Pass/fail policy: no query failures; ASAP-native relative error >5% warns (does not fail); latency regressions are warn-only on ephemeral GH runners. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Clarifies that the field marks sketch-based approximate queries (quantiles) where accuracy threshold enforcement applies, vs exact aggregations (avg/sum/max/min) where it does not. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Local/Cloudlab builds default to sketchdb-base:latest (built locally). CI overrides via BASE_IMAGE build arg to pull from GHCR, fixing the break reported in installation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
milindsrivastava1997
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha-<short-sha>tag, spins up the quickstart stack, waits for Arroyo pipeline + sketch ingestion, runs PromQL suite against both Prometheus (baseline) and ASAPQuery, compares accuracy and latency.${ASAP_IMAGE_TAG}so CI always tests latest committed code.compare.py,run_baseline.py,run_asap.py,wait_for_stack.sh,ingest_wait.sh(with null-data handling, Arroyo state detection, 600s timeout for UDF compilation).FROMtoghcr.iobase image so builds work in any job without a localsketchdb-baseimage.Pass/fail policy: no query failures allowed; ASAP-native relative error >5% warns (does not fail); latency regressions are warn-only on ephemeral GH runners.
Test plan
relative-regressionjob runs and reports latency comparison tableworkflow_dispatchworks withrunner: ubuntu-latest🤖 Generated with Claude Code