Add correctness CI: cross-language PromQL pattern matching parity tests#247
Merged
milindsrivastava1997 merged 1 commit intomainfrom Mar 30, 2026
Merged
Add correctness CI: cross-language PromQL pattern matching parity tests#247milindsrivastava1997 merged 1 commit intomainfrom
milindsrivastava1997 merged 1 commit intomainfrom
Conversation
- correctness.yml: Python/Rust token matching, serialised pattern comparison, and Rust unit tests on GH-hosted VMs - Add [workspace] table to three standalone test Cargo.toml files to prevent workspace conflict errors - Add test_data/promql_queries.json with 10 PromQL test cases covering ONLY_TEMPORAL, ONLY_SPATIAL, and ONE_TEMPORAL_ONE_SPATIAL patterns - Unignore test_data/*.json in asap-common/.gitignore - Fix PromQLPattern::new call sites and pattern_tests.rs: add *_over_time variants, remove duplicate ONLY_VECTOR key, add build_combined_quantile_pattern for 2-arg quantile_over_time Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
milindsrivastava1997
requested changes
Mar 28, 2026
asap-common/tests/compare_matched_tokens/rust_tests/src/pattern_tests.rs
Show resolved
Hide resolved
milindsrivastava1997
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[workspace]table in three standalone testCargo.tomlfiles to prevent workspace conflict errors.test_data/promql_queries.jsonwith 10 PromQL test cases coveringONLY_TEMPORAL,ONLY_SPATIAL, andONE_TEMPORAL_ONE_SPATIALpatterns.test_data/*.jsoninasap-common/.gitignore(fixture inputs, not generated output).PromQLPattern::newcall sites; updatepattern_tests.rs: add*_over_timevariants, remove duplicateONLY_VECTORkey, addbuild_combined_quantile_pattern.Test plan
🤖 Generated with Claude Code