Skip to content

refactor(asap-planner-rs): extract shared helpers for SQL/PromQL extensibility#238

Merged
milindsrivastava1997 merged 1 commit intomainfrom
refactor-asap-planner-rs-for-extensibility
Mar 28, 2026
Merged

refactor(asap-planner-rs): extract shared helpers for SQL/PromQL extensibility#238
milindsrivastava1997 merged 1 commit intomainfrom
refactor-asap-planner-rs-for-extensibility

Conversation

@milindsrivastava1997
Copy link
Copy Markdown
Contributor

@milindsrivastava1997 milindsrivastava1997 commented Mar 28, 2026

This PR just refactors some code in asap-planner-rs in preparation for adding SQL support.
SQL support is being added in #227 but that PR was being unwieldly so splitting into multiple PRs.

Created

  • build_sketch_parameters — core sketch param builder, query-language-agnostic
  • build_sketch_parameters_from_promql — PromQL wrapper around build_sketch_parameters
  • build_aggregation_entry — builds a single aggregation YAML entry
  • build_queries_yaml — builds the full queries YAML block
  • build_agg_configs_for_statistics — aggregation config loop, shared by both paths
  • get_sql_cleanup_param — SQL-specific cleanup param helper
  • get_label_routing — replaces compute_labels, extracts rollup/subpopulation label routing logic

Updated

  • parse_cleanup_policy, key_by_labels_to_yaml, params_to_yaml — made pub

Deleted

  • get_precompute_operator_parameters — replaced by build_sketch_parameters + build_sketch_parameters_from_promql
  • compute_labels — replaced by get_label_routing

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

…nsibility

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@milindsrivastava1997 milindsrivastava1997 merged commit 87383ed into main Mar 28, 2026
1 check passed
@milindsrivastava1997 milindsrivastava1997 deleted the refactor-asap-planner-rs-for-extensibility branch March 28, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants