Conversation
GnaneshGnani
commented
Mar 24, 2026
zzylol
previously approved these changes
Mar 25, 2026
Contributor
Author
|
@zzylol, I updated the sketchlib-rust dependency to the main branch since the corresponding branch changes have been merged. Please check whenever you have the time |
zzylol
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Code changes
asap-query-engine/src/drivers/ingest/otel.rs.HTTP OTLP request handling
Content-Encoding: gzipon OTLP HTTP requests.gzipis set, body is decompressed before protobuf decode.gRPC OTLP request handling
HTTPorgRPC) into request processing logs.Raw Metrics Flow behavior
format_series_key(name, labels).OTLP Raw Metrics Flow: received N raw metric seriesOTLP Raw Metrics Flow: series <series_key> count=<n>Sketch Payload Flow behavior
kll.sketch_payloadcms.sketch_payloadcountsketch.sketch_payloadSketchEnvelope::decode(...)(fromsketchlib-rust).KLL,CountMin,CountSketch) and payload metadata.Other; decode failures are logged withdecode_errorfor debugging.OTLP Sketches: metric='<metric>' attr='<attr>' payload_bytes=<n> sketch_type=<type>OTLP Sketch Payload Flow: received N sketch payload(s), decoded successfullyOTLP message handling summary
Common wire format (both flows):
POST /v1/metricsopentelemetry.proto.collector.metrics.v1.MetricsService/ExportExportMetricsServiceRequestgzip(or uncompressed)Routing behavior:
Verification
1) Start ASAPQuery OTLP receiver
From
ASAPQuery/:cd ASAPQuery RUST_LOG=query_engine_rust=debug ./target/release/query_engine_rust \ --enable-otel-ingest \ --otel-grpc-port 4317 \ --otel-http-port 4318 \ --kafka-topic dummy \ --input-format json \ --config asap-query-engine/examples/promql/inference_config.yaml \ --streaming-config asap-query-engine/examples/promql/streaming_config.yaml \ --streaming-engine arroyo \ --prometheus-scrape-interval 15 \ --output-dir /tmp/asapquery \ --query-language promql \ --lock-strategy globalExpected startup logs include OTLP listeners on
:4317(gRPC) and:4318(HTTP).2) Run DataCollector processors and load
From
DataCollector/opentelemetry-collector-contrib-patch/:Raw Metrics Flow example (
KLL):cd /home/gnanesh/ProjectASAP/DataCollector/opentelemetry-collector-contrib-patch ./KLL --config cmd/kll/asap_query_config/config-otlp-pathway1.yamlSketch Payload Flow example (
KLL, batch):cd /home/gnanesh/ProjectASAP/DataCollector/opentelemetry-collector-contrib-patch ./KLL --config cmd/kll/asap_query_config/config-otlp-pathway2-batch.yamlOther processor binaries/configs:
From
DataCollector/otel_collector_benchmark/:cd /home/gnanesh/ProjectASAP/DataCollector/otel_collector_benchmark go run main.go --endpoint localhost:53217 --workers 2 --hosts 5 --metrics 10 --duration 15s3) Validate receiver logs
Look for representative logs in ASAPQuery output:
OTLP received request via HTTPOTLP received request via gRPCOTLP ingest: received ... (transport=HTTP|gRPC)OTLP Raw Metrics Flow: received ...OTLP Sketches: metric=... attr=... payload_bytes=...OTLP Sketch Payload Flow: received ...