bench: add legacy-vs-current implementation comparison benchmarks for SimpleMapStore#222
Merged
milindsrivastava1997 merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Rewrites simple_store_bench.rs to benchmark all four store variants (LegacyPerKey, LegacyGlobal, NewPerKey, NewGlobal) across insert, range query, exact query, store-analyze, concurrent reads/writes, mixed read-write, cleanup overhead, query patterns, label cardinality, and multi-agg-id scenarios. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NewPerKey/NewGlobal implied a not-yet-merged implementation; renaming to CurrentPerKey/CurrentGlobal better reflects that these benchmark the current SimpleMapStore dispatch path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zzylol
changed the title
milindsrivastava1997
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_store_bench.rsto benchmark all four store variants:LegacyPerKey,LegacyGlobal,CurrentPerKey,CurrentGlobalStoreKindandAccumulatorKindenums for clean parameterisation across bothSumAccumulatorandDatasketchesKLLAccumulatorTest plan
cargo bench -p query_engine_rust --bench simple_store_benchruns without errorsStoreKindvariants produce results intarget/criterion/🤖 Generated with Claude Code