Skip to content

Rename SimpleMapStore impls to Legacy* and move to legacy/ submodule …#221

Merged
zzylol merged 2 commits intomainfrom
simple_store_opt
Mar 24, 2026
Merged

Rename SimpleMapStore impls to Legacy* and move to legacy/ submodule …#221
zzylol merged 2 commits intomainfrom
simple_store_opt

Conversation

@zzylol
Copy link
Copy Markdown
Contributor

@zzylol zzylol commented Mar 24, 2026

…(#220)

Move SimpleMapStoreGlobalLegacySimpleMapStoreGlobal and SimpleMapStorePerKeyLegacySimpleMapStorePerKey under a new simple_map_store/legacy/ submodule, in preparation for introducing optimised replacements that will reclaim the original names (PR #175 part b).

  • legacy/global.rs / legacy/per_key.rs: original implementations, renamed with the Legacy prefix throughout (struct, impl, log messages)
  • legacy/mod.rs: re-exports both legacy types
  • simple_map_store/mod.rs: references legacy module; SimpleMapStore enum now wraps LegacySimpleMapStoreGlobal / LegacySimpleMapStorePerKey
  • benches/simple_store_bench.rs: doc comment updated to reflect that the bench profiles the legacy store implementation

Public API (SimpleMapStore, Store) is unchanged.

zzylol and others added 2 commits March 23, 2026 23:19
…220)

Move `SimpleMapStoreGlobal` → `LegacySimpleMapStoreGlobal` and
`SimpleMapStorePerKey` → `LegacySimpleMapStorePerKey` under a new
`simple_map_store/legacy/` submodule, in preparation for introducing
optimised replacements that will reclaim the original names (PR #175 part b).

- `legacy/global.rs` / `legacy/per_key.rs`: original implementations,
  renamed with the `Legacy` prefix throughout (struct, impl, log messages)
- `legacy/mod.rs`: re-exports both legacy types
- `simple_map_store/mod.rs`: references legacy module; `SimpleMapStore`
  enum now wraps `LegacySimpleMapStoreGlobal` / `LegacySimpleMapStorePerKey`
- `benches/simple_store_bench.rs`: doc comment updated to reflect that
  the bench profiles the legacy store implementation

Public API (`SimpleMapStore`, `Store`) is unchanged.

Co-authored-by: zz_y <zz_y@node0.zz-y-296227.softmeasure-pg0.wisc.cloudlab.us>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@zzylol zzylol merged commit 3149cb8 into main Mar 24, 2026
4 checks passed
@zzylol zzylol deleted the simple_store_opt branch March 24, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant