198 migrate asap h2o benchmark pipeline to asapquery#216
Merged
milindsrivastava1997 merged 5 commits intomainfrom Mar 23, 2026
Merged
Conversation
milindsrivastava1997
requested changes
Mar 23, 2026
Contributor
milindsrivastava1997
left a comment
milindsrivastava1997
left a comment
There was a problem hiding this comment.
- Pls check failing CI
- Can you explain what each file is doing? I'm not sure I understand from the file names e.g. run_benchmark vs run_experiment
- What's the difference between asap_mode_queries.sql, asap_quantile_queries.sql and asap_h20_queries.sql?
Contributor
Author
CI fixed. I changed the file structure to look the same as Michael's benchmark, just forgot to delete old files. Everything should be the same as his now. asap_quantile_queries is the real one, others have been removed. |
milindsrivastava1997
approved these changes
Mar 23, 2026
milindsrivastava1997
deleted the
198-migrate-asap-h2o-benchmark-pipeline-to-asapquery
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working pipeline: uses same queries as Elastic pipeline equivalent - group by id1, id2 on 10s static time windows.
Including run_pipeline.sh for fully automated running, cleanup.sh for teardown and ensuring run-to-run consistency. Generates graphs per run, also has plot_latencies.py for comparing baseline and ASAP.