Changed exact string match to match based on SQLQueryData#197
Merged
milindsrivastava1997 merged 1 commit intomainfrom Mar 19, 2026
Conversation
STWMichael
approved these changes
Mar 19, 2026
milindsrivastava1997
deleted the
148-queryenginerust-should-not-do-an-exact-match-of-an-incoming-query-against-inference_config-for-sql-queries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, asap-query-engine does an exact string match of each incoming SQL query to queries in the inference_config. This breaks for cases where the incoming queries has absolute timestamps in the SQL WHERE clause but the inference config uses
NOW(). This PR changes the exact string match to instead match based on the parsedSQLQueryDatastructure.