Merged
Conversation
- Delete commenting_out_flink_diff temp file - Remove StreamingEngine enum (Flink/Arroyo variants no longer needed) - Remove --streaming-engine CLI arg from main.rs - Remove streaming_engine field from KafkaConsumerConfig - Remove StreamingEngine::Flink match arm and all commented-out Flink message handling from kafka.rs - Remove deserialize_from_json_flink commented-out method from precomputed_output.rs - Simplify create_precompute_from_bytes: remove streaming_engine param and replace all Flink/Arroyo conditionals with direct arroyo calls - Clean up residual Flink references in accumulator files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep StreamingEngine enum and --streaming-engine CLI arg but with only the Arroyo variant (Flink variant removed). Also fix cargo fmt issues. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@milindsrivastava1997 This PR looks simple and correct, just removing Flink part of the code. Can I merge it to the main? |
milindsrivastava1997
approved these changes
Mar 11, 2026
Contributor
|
LGTM. Pls merge after CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingEngineenum,--streaming-engineCLI arg, andstreaming_enginefield fromKafkaConsumerConfig— no longer needed now that only Arroyo is supportedStreamingEngine::Flinkmatch arm and all commented-out Flink JSON message handling fromkafka.rsdeserialize_from_json_flinkmethod and simplifycreate_precompute_from_bytes(dropstreaming_engineparam, replace Flink/Arroyo conditionals with direct arroyo calls) inprecomputed_output.rscommenting_out_flink_difftemp file and clean up residual Flink references in accumulator filesTest plan
cargo buildpasses (verified locally — no new warnings)🤖 Generated with Claude Code