Skip to content

Add workflow and dependency analysis - #23

Merged
Leitwolf11 merged 2 commits into
mainfrom
ci/analysis-tools
Oct 10, 2026
Merged

Leitwolf11 merged 2 commits into
mainfrom
ci/analysis-tools

Conversation

@Leitwolf11

@Leitwolf11 Leitwolf11 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

What changes

Nothing looked at the workflows themselves, or at a dependency at the moment it comes in. This adds that.

  • zizmor (zizmor.yml) audits the workflows and uploads its findings to code scanning. Run locally, it found one thing 2 times: a checkout that leaves the job's token in the checked-out repository. No workflow pushes or uses the token after the checkout, so every checkout now sets persist-credentials: false, and zizmor reports nothing.
  • Dependency Review (dependency-review.yml) fails a pull request that brings in a dependency with a known vulnerability of high severity or worse. Dependabot watches what is already there; this holds what comes in.

Secret scanning with push protection is already enabled in the repository settings, so nothing is added for it.

An OpenSSF Scorecard workflow was part of the first commit of this branch and is removed by the second: the owner decided against it. No REUSE check is added either, for the same reason.

Every new action is pinned to a commit, each job names the permissions it needs, and the new workflows have no default permission. The existing workflows change by one line per checkout.

Verification

zizmor --offline .github/workflows     before: 2 findings (artipacked); after: none
every workflow parses as YAML; all 5 checkouts set persist-credentials: false
git diff --check                        clean

Not run locally: the new workflows themselves (Dependency Review needs GitHub), and zizmor's online audits, which the workflow runs with the job's token. No source file is touched.

This is a self-review by the author of the branch.

Leitwolf11 added 2 commits October 10, 2026 20:22
zizmor audits the workflows themselves for what makes a workflow
unsafe, and uploads what it finds to code scanning. Its first run here
found one thing, 2 times: a checkout that leaves the job's token in
the checked-out repository, where any later step can read it. No
workflow pushes or needs the token after the checkout, so every checkout
now sets persist-credentials to false, and zizmor reports nothing.

OpenSSF Scorecard grades how the repository is kept: branch protection,
pinned dependencies, token permissions and the like. It runs on the
default branch and weekly, publishes its score and uploads its findings to
code scanning.

Dependency Review fails a pull request that adds or changes a dependency
with a known vulnerability of high severity or worse. Dependabot watches
what is already there; this holds what comes in.

Every new action is pinned to a commit, each job names the permissions
it needs, and no new workflow has a default permission.
The owner decided against running OpenSSF Scorecard here. The workflow
added by the commit before this one is removed; nothing else changes.
@Leitwolf11 Leitwolf11 changed the title Add workflow, repository and dependency analysis Add workflow and dependency analysis Oct 10, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@Leitwolf11
Leitwolf11 merged commit f0f38cb into main Oct 10, 2026
9 checks passed
@Leitwolf11
Leitwolf11 deleted the ci/analysis-tools branch October 10, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants