Repository navigation
Tokenize the method reference sign of Visual X# - #21
Merged
Merged
Conversation
Visual X# 0.5.0 implements the method reference `Type::Method`, and its lexer has `::` as one sign. The tokenizer that colours Visual X# listed the compiler's signs without it, so the reference was two colons of punctuation. `::` is now an operator of the list, ahead of the single colon, as in the compiler. The tests hold a reference between two names, a reference whose type is written through its namespace, that a single colon is still the punctuation of a conditional, and a conditional that selects strings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI or model change
The
syntaxmodule owns this.VisualXSharpTokenizerlists the signs of the Visual X# lexer, and Visual X# 0.5.0 (Progmasoft/tala#42, not merged yet) adds::, the method reference ofType::Method. Without it the editor showed a reference as two colons of punctuation.::is now one operator token, listed ahead of the single colon, as in the compiler.Nothing else of 0.5.0 needs a change here: the keyword list already matches the compiler's lexer, names written through a namespace are names and dots, and a conditional over strings tokenizes as before. Operators keep the editor's text colour, so the visible change is small; the token boundary is what later features read.
No XIT change.
Verification
checkwere run.git diff --checkwere checked.Commands and results (including anything not run):
Not run: macOS and Linux. The UI and persistence items are unchecked because neither is affected.
Screenshots or recordings for visual changes: none; operators are not coloured.