chore: remove broken test files#23
Conversation
- Removed 16 temporary .md files used during development - Removed cleanup scripts for production cleanliness - Cleaned git history for Kaggle submission requirements
Summary of ChangesHello @ProfRandom92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on repository maintenance by eliminating outdated and non-functional test files that were hindering the test suite's integrity. Concurrently, it purges a significant number of documentation and script files, primarily those detailing Kaggle submission processes and historical project status, to simplify the repository structure and ensure only relevant information remains. The goal is to improve the overall health and clarity of the codebase by removing technical debt and extraneous content. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a necessary cleanup by removing several obsolete documentation files and two broken test files. The removal of test_compression_edge_cases.py and test_triage_boundaries.py is justified as they were based on incorrect API assumptions. This change helps to streamline the test suite and reduce maintenance overhead. As a follow-up, please consider updating the README.md file, as it still references the deleted test files in the 'Project Structure' section. Overall, this is a good housekeeping change.
There was a problem hiding this comment.
Pull request overview
This pull request removes broken test files and outdated documentation from the MedGemma CompText project. The changes include deleting two test files that had incorrect API assumptions, removing a branch cleanup script, and removing multiple Kaggle submission guide documents and session status files.
Changes:
- Removed test files with incorrect API calls (
test_triage_boundaries.py,test_compression_edge_cases.py) - Removed branch cleanup utility script (
cleanup_branches.sh) - Removed Kaggle submission documentation and session status files (10+ markdown files)
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_triage_boundaries.py | 284-line test file deleted - called non-existent triage() method instead of assess() |
| tests/unit/test_compression_edge_cases.py | 393-line test file deleted - used wrong PatientState attributes (vital_signs.heart_rate vs vitals.hr) |
| cleanup_branches.sh | 71-line bash script deleted - utility for cleaning up git branches |
| SUBMISSION_QUICK_START_GUIDE.md | 282-line Kaggle submission guide deleted |
| SUBMISSION_QUICK_REFERENCE.md | 184-line quick reference card deleted |
| SESSION_6_FINAL_STATUS.md | 342-line session status document deleted |
| SESSION_5_FINAL_STATUS.md | 210-line session status document deleted |
| SESSION_4_FINAL_COMPLETION_STATUS.md | 319-line completion status document deleted |
| READY_FOR_KAGGLE_SUBMISSION.md | 325-line submission readiness document deleted |
| PHASE_4E_TEST_STRATEGY.md | 423-line test strategy document deleted |
| PHASE_4E_PROGRESS.md | 247-line progress tracking document deleted |
| KAGGLE_SUBMISSION_STRATEGY.md | 392-line submission strategy document deleted |
| KAGGLE_SUBMISSION_MASTER_INDEX.md | 294-line master index document deleted |
| KAGGLE_SUBMISSION_FINAL_EXECUTION.md | 258-line execution guide deleted |
| KAGGLE_SUBMISSION_CHECKLIST.md | 293-line submission checklist deleted |
| KAGGLE_NOTEBOOK_READY_TO_PASTE.md | 559-line notebook template deleted |
| KAGGLE_MANUAL_SUBMISSION_GUIDE.md | 407-line manual guide deleted |
| CLEANUP_COMPLETED.md | 90-line cleanup status document deleted |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed broken test files that had incorrect API assumptions:
Keeping api_error_handling tests (32 passing) as primary test suite.
CI will validate remaining tests.