-
Notifications
You must be signed in to change notification settings - Fork 0
Add minimal root npm wrapper #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,14 @@ | ||||||
| { | ||||||
| "name": "comptextv7-root", | ||||||
| "private": true, | ||||||
| "scripts": { | ||||||
| "build": "npm --prefix dashboard/app run build && npm --prefix showcase/app run build", | ||||||
| "typecheck": "npm --prefix dashboard/app run typecheck && npm --prefix showcase/app run typecheck", | ||||||
| "validate": "npm --prefix showcase/app run validate", | ||||||
| "test": "pytest -q", | ||||||
| "test:core": "pytest tests/test_core_foundation_ts.py -q", | ||||||
| "test:replay": "pytest tests/test_paper_replay_bench.py tests/test_agent_trace_replay.py tests/test_replay_continuity.py -q", | ||||||
| "layout": "python scripts/check_repo_layout.py", | ||||||
| "check": "npm run layout && npm run typecheck && npm run validate && npm run build && npm run test" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Python tests run by
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| from scripts.check_repo_layout import check_repo_layout | ||
| from scripts.check_repo_layout import REPO_ROOT, check_repo_layout | ||
|
|
||
|
|
||
| def test_expected_repo_layout_is_present(): | ||
| assert (REPO_ROOT / "package.json").is_file() | ||
| assert (REPO_ROOT / "dashboard" / "app" / "package.json").is_file() | ||
| assert (REPO_ROOT / "showcase" / "app" / "package.json").is_file() | ||
|
Comment on lines
+5
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These assertions are redundant. The |
||
| assert check_repo_layout() == [] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid duplicating documentation, consider removing this list of commands from
README.md. The preceding sentence already directs users todocs/validation.mdfor validation commands, and that file now contains a comprehensive explanation of these root wrapper scripts. Centralizing this information makes it easier to maintain.