Polish deterministic replay showcase dashboard#81
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for comptext-v7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the showcase application to focus on deterministic operational replay validation for AI agents. Key changes include the introduction of a centralized data module for benchmark artifacts, a streamlined React dashboard in main.tsx, and updated validation scripts to ensure content integrity. Feedback from the review highlights opportunities to improve maintainability and portability by reducing hardcoded values in the validation script and the main application, specifically regarding hero metrics and the repository base URL.
| for (const value of ['1.347063', '0.791667', '1.773954', '1.000000', '0.000000']) { | ||
| if (!data.includes(value)) { | ||
| console.error(`Missing committed artifact value: ${value}`); | ||
| process.exit(1); | ||
| } | ||
| } |
There was a problem hiding this comment.
The validation script hardcodes specific benchmark values for assertion. This makes the CI pipeline brittle, as any update to the benchmark artifacts will require manual updates in three separate locations: the JSON artifact, the data module, and this validation script. A more robust approach would be to read the expected values directly from the committed JSON artifacts and verify that the showcase data module reflects them.
| import { artifactLinks, benchmarkArtifacts } from './data/benchmarkArtifacts'; | ||
| import './styles.css'; | ||
|
|
||
| const repoBase = 'https://github.com/ProfRandom92/Comptextv7/blob/main/'; |
There was a problem hiding this comment.
The repository base URL is hardcoded with a specific username and branch. This makes the showcase less portable and prone to breaking if the repository is moved, renamed, or if the default branch changes. Consider using a relative path if possible, or defining this as a configurable environment variable.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Motivation
Description
showcase/app/src/main.tsx).showcase/app/src/data/benchmarkArtifacts.ts).showcase/app/src/styles.css).showcase/app/scripts/validate-static.mjs).Testing
npm run typecheck,npm run validate, andnpm run buildinshowcase/appand all commands completed successfully.npm run typecheck,npm run smoke:release-health, andnpm run buildindashboard/appand all commands completed successfully.Codex Task